Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix production external images not displaying #324

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

JohnsonMao
Copy link
Contributor

Why need this change? / Root cause:

  • fix production external images not displaying

Changes made:

Test Scope / Change impact:

  • Avater component image

Issue

Note

不知道為什麼部屬在預覽網站可以正常顯示照片,部屬到正式機後卻沒吃到 next.config.js 的 image unoptimized 設定,所以我目前先暫時調整 Avater 裡面的 image 個別設定 unoptimized,有時間再研究為什麼 next.config.jsunoptimized 設定會失效

預覽版的登入頁

image

正式機的登入頁

image

@JohnsonMao JohnsonMao added bug Fix something in main sprint 9 labels Sep 17, 2023
@JohnsonMao JohnsonMao self-assigned this Sep 17, 2023
@vercel
Copy link

vercel bot commented Sep 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
game-lobby-web ✅ Ready (Inspect) Visit Preview Sep 17, 2023 10:06am

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Sep 17, 2023

Knip Scan Result for 2f88cd7

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Sep 17, 2023

🤖 Lighthouse Scan Result for 2f88cd7

/rooms
Metric Value
Performance 58
Seo 80
Accessibility 77
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 73
Seo 80
Accessibility 66
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 45
Seo 80
Accessibility 94
HTML Report for LHCI Scan Report Link

@JohnsonMao JohnsonMao merged commit ce60967 into main Sep 18, 2023
9 checks passed
@JohnsonMao JohnsonMao deleted the feature/next-image-config branch September 18, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix something in main sprint 9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: 遊戲圖片無法顯示
4 participants