-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Socket.IO connects with the jwt token #321
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
2f6dedb
to
4ab478f
Compare
✅ Knip Scan Result for 13dd770 Unused files (10)
Unused dependencies (2)
Unused devDependencies (5)
Configuration issues (1)
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
🤖 Lighthouse Scan Result for 13dd770 /rooms
/rooms/abc
/login
|
Why need this change? / Root cause:
Changes made:
Test Scope / Change impact:
Issue
Note
原本的 Socket.IO 是固定參數,這次需求改為動態帶 auth token
Reference
https://socket.io/docs/v4/middlewares/#sending-credentials