Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add socket event of join room and leave room #319

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

Yuwen-ctw
Copy link
Contributor

Why need this change? / Root cause:

  • Implement JOIN_ROOM and LEAVE_ROOM socket events

Changes made:

  • Modify the payload and event names of existing and corresponding events.

Test Scope / Change impact:

Issue

  • 看了程式碼才知道,其實過去尚未正式定案的「加入與離開聊天室事件」相關程式碼尚未移除,因此本次 PR 僅須微調事件名稱與事件訊息即可。

@Yuwen-ctw Yuwen-ctw added refactor refactor the changes already merged. spring 10 labels Sep 12, 2023
@Yuwen-ctw Yuwen-ctw self-assigned this Sep 12, 2023
@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
game-lobby-web ✅ Ready (Inspect) Visit Preview Sep 12, 2023 11:27am

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GaaSBot
Copy link

GaaSBot commented Sep 12, 2023

Knip Scan Result for 19eaedd

Unused files (10)
Unused files (10)
.bundlewatch.config.js
components/shared/Chat/ChatContent.tsx
components/shared/Chat/ChatMessage.tsx
components/shared/Chat/index.tsx
components/shared/Icon/group/news.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Sep 12, 2023

🤖 Lighthouse Scan Result for 19eaedd

/rooms
Metric Value
Performance 63
Seo 80
Accessibility 77
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 72
Seo 80
Accessibility 66
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 48
Seo 80
Accessibility 94
HTML Report for LHCI Scan Report Link

Copy link
Contributor

@JohnsonMao JohnsonMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JohnsonMao JohnsonMao merged commit 58a31c9 into main Sep 17, 2023
9 checks passed
@JohnsonMao JohnsonMao deleted the feat/socket-event-of-room-join-and-leave branch September 17, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactor the changes already merged. spring 10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: 新增 加入/離開房間 Socket 事件
3 participants