Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notify price changes #57

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion history/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{
"extends": "../eslintrc.base.json"
"extends": "../eslintrc.base.json",
"ignorePatterns": ["proto"]
}
9 changes: 8 additions & 1 deletion history/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"db:migrate": "knex --knexfile ./src/config/database.ts migrate:latest",
"db:rollback": "knex --knexfile ./src/config/database.ts migrate:rollback",
"db:create:seed": "knex --knexfile ./src/config/database.ts seed:make -x ts",
"db:seed": "knex --knexfile ./src/config/database.ts seed:run"
"db:seed": "knex --knexfile ./src/config/database.ts seed:run",
"codegen:notifications": "cd src/services/notifications/proto && buf generate"
},
"dependencies": {
"@grpc/grpc-js": "^1.9.12",
Expand All @@ -39,12 +40,18 @@
"ajv": "^8.12.0",
"ccxt": "^4.1.70",
"dotenv": "^16.0.3",
"google-protobuf": "^3.21.2",
"grpc-health-check": "^2.0.0",
"js-yaml": "^4.1.0",
"knex": "^3.0.1",
"lodash.merge": "^4.6.2",
"node-cron": "^3.0.3",
"pg": "^8.11.0",
"pino": "^8.16.2"
},
"devDependencies": {
"grpc-tools": "^1.12.4",
"grpc_tools_node_protoc_ts": "^5.3.3",
"protoc-gen-js": "^3.21.2"
}
}
1 change: 1 addition & 0 deletions history/src/app/history/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
export * from "./get-price-history"
export * from "./update-price-history"
export * from "./notify-price-change"
4 changes: 4 additions & 0 deletions history/src/app/history/index.types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@ type GetPriceHistoryArgs = {
currency: string
range?: string
}

type NotifyPriceChangeArgs = {
range?: PriceRange
}
36 changes: 36 additions & 0 deletions history/src/app/history/notify-price-change.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
import { defaultBaseCurrency } from "@config"
import { PriceRange, PriceRepositoryError } from "@domain/price"
import { checkedToCurrency } from "@domain/primitives"
import { PriceRepository } from "@services/database"
import { NotificationsService } from "@services/notifications"

export const notifyPriceChange = async ({ range }: NotifyPriceChangeArgs) => {
UncleSamtoshi marked this conversation as resolved.
Show resolved Hide resolved
const quote = checkedToCurrency("USD")

if (quote instanceof Error) {
return quote
}

const rangeToQuery = range || PriceRange.OneDay
const prices = await PriceRepository().listPrices({
base: defaultBaseCurrency,
quote,
range: rangeToQuery,
})

if (prices instanceof PriceRepositoryError) {
return prices
}

if (prices.length < 2) {
return
}

const notificationsService = NotificationsService()

return notificationsService.priceChanged({
initialPrice: prices[0],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dolcalmi is this the correct index? Is the earliest price first in the result?

finalPrice: prices[prices.length - 1],
range: rangeToQuery,
})
}
2 changes: 2 additions & 0 deletions history/src/config/process.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ export const databaseConfig = {
poolMax: parseInt(process.env.DB_POOL_MAX || "", 10) || 5,
debug: process.env.DB_DEBUG === "true",
}

export const notificationsEndpoint = process.env.notificationsEndpoint || "localhost:6685"
6 changes: 6 additions & 0 deletions history/src/domain/notifications/errors.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { ErrorLevel, ServiceError } from "../errors"

export class NotificationsServiceError extends ServiceError {}
export class UnknownNotificationServiceError extends NotificationsServiceError {
level = ErrorLevel.Critical
}
1 change: 1 addition & 0 deletions history/src/domain/notifications/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from "./errors"
11 changes: 11 additions & 0 deletions history/src/domain/notifications/index.types.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
type NotificationsServiceError = import("./errors").NotificationsServiceError

interface INotificationsService {
priceChanged(args: PriceChangedArgs): Promise<void | NotificationsServiceError>
}

type PriceChangedArgs = {
range: PriceRange
initialPrice: Tick
finalPrice: Tick
}
1 change: 1 addition & 0 deletions history/src/servers/history/cron.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ dotenv.config()

const startServer = async () => {
await History.updatePriceHistory()
await History.notifyPriceChange({})
await closeDbConnections()
}

Expand Down
38 changes: 38 additions & 0 deletions history/src/services/notifications/grpc-client.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import { promisify } from "util"

import { credentials, Metadata } from "@grpc/grpc-js"

import { NotificationsServiceClient } from "./proto/notifications_grpc_pb"
import {
HandleNotificationEventRequest,
HandleNotificationEventResponse,
} from "./proto/notifications_pb"

export type GrpcNotificationsClientConfig = {
notificationsApi: string
}

export const GrpcNotificationsClient = ({
notificationsApi,
}: GrpcNotificationsClientConfig) => {
const notificationsClient = new NotificationsServiceClient(
notificationsApi,
credentials.createInsecure(),
)
const metadata = new Metadata()

const handleNotificationEvent = (request: HandleNotificationEventRequest) => {
return promisify<
HandleNotificationEventRequest,
Metadata,
HandleNotificationEventResponse
>(notificationsClient.handleNotificationEvent.bind(notificationsClient))(
request,
metadata,
)
}

return {
handleNotificationEvent,
}
}
39 changes: 39 additions & 0 deletions history/src/services/notifications/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import { notificationsEndpoint } from "@config"
import {
NotificationsServiceError,
UnknownNotificationServiceError,
} from "@domain/notifications"

import { GrpcNotificationsClient } from "./grpc-client"
import { createPriceChangedEvent } from "./price-changed-event"
import {
HandleNotificationEventRequest,
NotificationEvent,
} from "./proto/notifications_pb"

export const NotificationsService = (): INotificationsService => {
const grpcClient = GrpcNotificationsClient({
notificationsApi: notificationsEndpoint,
})

const priceChanged = async (
args: PriceChangedArgs,
): Promise<void | NotificationsServiceError> => {
try {
const req = new HandleNotificationEventRequest()
const event = new NotificationEvent()
const priceChangedEvent = createPriceChangedEvent(args)
event.setPrice(priceChangedEvent)
req.setEvent(event)
await grpcClient.handleNotificationEvent(req)
} catch (err) {
if (err instanceof Error) {
return new NotificationsServiceError(err.message)
}
return new UnknownNotificationServiceError(err.toString())
}
}
return {
priceChanged,
}
}
28 changes: 28 additions & 0 deletions history/src/services/notifications/price-changed-event.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { Money, PriceChangeDirection, PriceChanged } from "./proto/notifications_pb"

export const createPriceChangedEvent = ({
initialPrice,
finalPrice,
}: PriceChangedArgs) => {
const priceChange = calculatePriceChangePercentage(initialPrice.price, finalPrice.price)

const priceOfOneBitcoin = new Money()
priceOfOneBitcoin.setMinorUnits(usdMajorUnitToMinorUnit(finalPrice.price))
priceOfOneBitcoin.setCurrencyCode("USD")

const priceChangedEvent = new PriceChanged()
priceChangedEvent.setPriceOfOneBitcoin(priceOfOneBitcoin)
priceChangedEvent.setDirection(priceChange.direction)
priceChangedEvent.setPriceChangePercentage(priceChange.percentage)
return priceChangedEvent
}

const usdMajorUnitToMinorUnit = (usd: number) => usd * 100

const calculatePriceChangePercentage = (initialPrice: Price, finalPrice: Price) => {
const percentage = ((finalPrice - initialPrice) / initialPrice) * 100

const direction =
finalPrice > initialPrice ? PriceChangeDirection.UP : PriceChangeDirection.DOWN
return { percentage, direction }
UncleSamtoshi marked this conversation as resolved.
Show resolved Hide resolved
}
15 changes: 15 additions & 0 deletions history/src/services/notifications/proto/buf.gen.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# /proto/buf.gen.yaml
version: v1

plugins:
- name: js
out: .
opt: import_style=commonjs,binary
- name: grpc
out: .
opt: grpc_js
path: grpc_tools_node_protoc_plugin
- name: ts
out: .
opt: grpc_js
path: protoc-gen-ts
Loading
Loading