Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: tf module to find common latest k8s version across 3 regions #214

Merged
merged 2 commits into from
Sep 2, 2024
Merged

ci: tf module to find common latest k8s version across 3 regions #214

merged 2 commits into from
Sep 2, 2024

Conversation

sandipndev
Copy link
Member

@sandipndev sandipndev commented Sep 2, 2024 •
edited
Loading 

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Outputs:

latest_version = "1.28.13-gke.1006000"

@sandipndev sandipndev changed the title ci: tf module to find common across 3 regions ci: tf module to find common latest k8s version across 3 regions Sep 2, 2024
@sandipndev sandipndev merged commit ead1f76 into main Sep 2, 2024
1 check passed
bodymindarts
bodymindarts reviewed Sep 2, 2024
View reviewed changes
ci/k8s-upgrade/main.tf
version_prefix = "1.28."
project = "galoy-infra-testflight"
}

data "google_container_engine_versions" "euwest6" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't a for-each work with a list of locations?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - I didn't think about that
wanted to keep it simple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodymindarts bodymindarts bodymindarts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandipndev @bodymindarts