Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(apps): fix dashboard/voucher/consent tests #4627

Merged
merged 21 commits into from
Oct 24, 2024
Merged

test(apps): fix dashboard/voucher/consent tests #4627

merged 21 commits into from
Oct 24, 2024

Conversation

dolcalmi
Copy link
Collaborator

@dolcalmi dolcalmi commented Oct 20, 2024 •
edited
Loading

Github Actions

  • Integration tests: reduces execution time ~10 mins with the benefit of restart failed jobs for specific apps (caused by infra issues). before -> after
  • E2E tests: add additional builds to avoid bats setup issues because of timeouts (caused by builds)

Tests

  • Reverts next version because of a known issue with URL helper method that cause tests crashes
  • Fix cookie name issues caused for hydra update (now is a long token that cause errors with tests)
  • Fix csrf issue with consent login test
  • Fix dashboard issue that caused tests to fail because of an unintended refresh
  • Refactor api key creation component in dashboard
  • Refactor voucher and dashboard auth for tests (remove NEXT_AUTH_SESSION_TOKEN hack and now use cy.session)
  • Fix mui deprecations
  • Fix Tilt resources deps

@dolcalmi dolcalmi force-pushed the test-fix-dashboard-auth branch 2 times, most recently from a608317 to 294d617 Compare October 21, 2024 09:53
@dolcalmi dolcalmi force-pushed the test-fix-dashboard-auth branch from 294d617 to 1514dd2 Compare October 21, 2024 10:23
@github-actions github-actions bot added the ci label Oct 22, 2024
@dolcalmi dolcalmi force-pushed the test-fix-dashboard-auth branch from 9e42bee to aabddc7 Compare October 22, 2024 01:06
@dolcalmi dolcalmi force-pushed the test-fix-dashboard-auth branch 2 times, most recently from e2209b6 to c0cb11f Compare October 22, 2024 01:38
@dolcalmi dolcalmi force-pushed the test-fix-dashboard-auth branch 14 times, most recently from bf5498f to 62845a9 Compare October 23, 2024 21:02
@dolcalmi dolcalmi force-pushed the test-fix-dashboard-auth branch from 62845a9 to b1b7f2d Compare October 23, 2024 21:47
@dolcalmi dolcalmi changed the title test(apps): fix dashboard/voucher auth test test(apps): fix dashboard/voucher/consent test Oct 23, 2024
@dolcalmi dolcalmi changed the title test(apps): fix dashboard/voucher/consent test test(apps): fix dashboard/voucher/consent tests Oct 23, 2024
@dolcalmi dolcalmi marked this pull request as ready for review October 23, 2024 22:02
@dolcalmi dolcalmi requested a review from openoms October 23, 2024 22:12
openoms
openoms approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@openoms openoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the tests passing.

Will need to test the API key creation in the Dashboard and the Voucher flow on staging.

@dolcalmi dolcalmi merged commit 9ba4832 into main Oct 24, 2024
17 checks passed
This was referenced Oct 24, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@openoms openoms openoms approved these changes

Assignees
No one assigned
Labels
admin-panel ci consent core dashboard map pay voucher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dolcalmi @openoms