feat: add onfido onboarding for bank transfer #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasburtey
force-pushed
the
chore--test-onfido
branch
6 times, most recently
from
5fd0829 to
a0bd167
Compare
| } | ||
|
|
||
| return ( | ||
| <Screen |
There was a problem hiding this comment.
It would be nice to lay out this screen similar to how we style other screens. Here is how its styled in the send flow. It uses padding of 20, and then the PrimaryButton is aligned with the bottom of the screen. https://github.com/GaloyMoney/galoy-mobile/blob/b60b1e086f3b3a4f47caf41f9a00dd010006bc28/app/screens/send-bitcoin-screen/send-bitcoin-details-screen.tsx#L643
| keyboardOffset="navigationHeader" | ||
| > | ||
| <View style={styles.screenContainer}> | ||
| <Text style={styles.textHeader}>{LL.FullOnboarding.requirements()}</Text> |
There was a problem hiding this comment.
Are you able to use a type="h1" instead of a unique text style.
nicolasburtey
force-pushed
the
chore--test-onfido
branch
from
a0bd167 to
574c686
Compare
nicolasburtey
force-pushed
the
chore--test-onfido
branch
from
43b4f67 to
dd3792e
Compare
nicolasburtey
force-pushed
the
chore--test-onfido
branch
2 times, most recently
from
ef81688 to
6a714d5
Compare
nicolasburtey
changed the title
nicolasburtey
force-pushed
the
chore--test-onfido
branch
from
6a714d5 to
9bc31fb
Compare
UncleSamtoshi
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.