This repository has been archived by the owner on Mar 8, 2024. It is now read-only.
fix mega DT #396
Merged
fix mega DT #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueWeabo
reviewed
Feb 29, 2024
.../bartimaeusnek/bartworks/common/tileentities/multis/mega/GT_TileEntity_MegaDistillTower.java
Outdated
Show resolved
Hide resolved
Lyfts
reviewed
Feb 29, 2024
| while (this.mHeight < 12 && this.checkPiece(STRUCTURE_PIECE_LAYER, 7, this.mHeight * 5, 0) | ||
| && !this.mTopLayerFound) { | ||
| while (this.mHeight < 12) { | ||
| if (!checkPiece(STRUCTURE_PIECE_LAYER, 1, mHeight * 5, 0)) { |
There was a problem hiding this comment.
Horizontal offset should be 7 here right?
|
I've rechecked this PR in its entirety now and there should be no more copypaste errors |
Dream-Master
approved these changes
Mar 3, 2024
|
Okay this got turbo merged... It doesn't actually fix it tho. The entire top can still be missing as long as the first block it checks is present. |
|
Oh lol disregard that I checked out the wrong branch |
mitchej123
pushed a commit
that referenced
this pull request
Mar 8, 2024
* fix mega dt structure * fix copypaste error * fix copypaste error again Former-commit-id: 0aa8a95b61676ede1433ce359aecf00c2aec1e45
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #395
related to GTNewHorizons/GT5-Unofficial#865
fix structure check successing when top layer isn't correctly built