This repository has been archived by the owner on Mar 8, 2024. It is now read-only.
remove unused ASM #371
Merged
remove unused ASM #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's likely that this can be cleaned up further, the RWG ASM could go into RWG itself, if we determine what it is doing and why. |
|
Warning: 2 uncommitted changes |
Caedis
approved these changes
Nov 30, 2023
mitchej123
pushed a commit
that referenced
this pull request
Mar 8, 2024
* remove unused ASM * accidentally removed too much * Remove RWG ASM * spotlessApply --------- Co-authored-by: Caedis <[email protected]> Co-authored-by: GitHub GTNH Actions <unknown> Former-commit-id: 5238bf977343cbfbf20b6e8b6c27ebeabd0ae1c9
mitchej123
pushed a commit
that referenced
this pull request
Mar 8, 2024
* remove unused ASM * accidentally removed too much * Remove RWG ASM * spotlessApply --------- Co-authored-by: Caedis <[email protected]> Co-authored-by: GitHub GTNH Actions <unknown> Former-commit-id: ea5a2a8199749234e1e144c9f326ddd1b23e30c8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes unused asm (either we config it off, or it literally just did nothing except print [UNUSED].
Full pack loads but someone who knows more about ASM may want to take a look. It's certainly a way of deciding what to ASM.
Also refactored a spelling error.