Fix MDT void protection #367
Conversation
|
While this works as a temporary solution, I think giving void protection support for ME buses/hatches and throwing away |
I agree that implementing a proper solution would be a better option, since another issue on my list is to check why a certain MCR is refusing to run due to missing output space (while also being connected to ME output bus/hatch combo). For this issue I wanted to implement something that can be hotfixed for 2.4.X version since it was affecting my world. And current implementation is simply wrong for MDT. Do you think that we can proceed with this fix or should a broader fix be rolled out first? @miozune |
.../bartimaeusnek/bartworks/common/tileentities/multis/mega/GT_TileEntity_MegaDistillTower.java
Outdated
Show resolved
Hide resolved
.../bartimaeusnek/bartworks/common/tileentities/multis/mega/GT_TileEntity_MegaDistillTower.java
Outdated
Show resolved
Hide resolved
* Update buildscript. * Implement custom MDT logic for dumping fluid to ME. * Code cleanup. Former-commit-id: 7871fca4a3371822cec3dc1d9adf190853bed005
* Update buildscript. * Implement custom MDT logic for dumping fluid to ME. * Code cleanup. Former-commit-id: 37d1e00c283ef1ae8b03150212c3ca425b0ef3b5
I've noticed that two MDTs (Mega Distillation Tower) had a fairly high tick time in my world. After a quick inspection it seemed to one tick despite batch mode being enabled. After a quick check it turned out that disabling void protection helped and multi didn't actually void anything (as it was connected to ME output hatch).
I had a similar setup for MVF (Mega Vacuum Freezer) that worked correctly so MDT seemed to be the problem.
What is happening is that MDT has special logic to output per layer, original code was not detecting any hatches so it would throttle production.
I've changed this logic to detect ME Output Hatch per layer, and if all layers have a hatch then assume this multi does not need to go through full void protection pass.