Thermos Compat with postNeidWorldsSupport #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: 2 uncommitted changes |
…ess-fixes Spotless apply for branch thermos-nibble-compat for #22
boubou19
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When postNeidWorldsSupport is disabled, that means the vanilla
BlocksandDatabyte[] values no longer get stored in the NBT. This means that duringreadChunkFromNBT, the NibbleArray created for the block metadata, gets created with an empty byte[].Thermos(specifically spigot), makes this change to NibbleArray, which causes it to crash when created with an empty byte[]. So this change injects a static fake byte[] with one value in it that will be passed into the NibbleArray creation, instead of trying to pull the value from the
DataNBT tag.