Fix chest flickering when a barrel is in sight #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix is maybe fine, but if the underlying issue is Angelica not handling the GL lighting states properly in GLSM, then we need to fix that in Angelica, we should leave this open for the moment until someone looks into it on the Angelica side and sees if we can fix the underlying problem there instead. |
|
ok I'll make an issue on Angelica side |
4 tasks
|
it work for me. |
|
Also closes GTNewHorizons/GT-New-Horizons-Modpack#16233 (410 was a duplicate of this) |
|
@mitchej123 so you are aware |
Caedis
approved these changes
Jul 7, 2024
|
Been working without issue and fixed the flickering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GTNewHorizons/GT-New-Horizons-Modpack#16410
We must use vanilla enableStandardItemLighting() to render GT ores correctly.
However, Vanilla enableStandardItemLighting() leaks directional light setting and ambient light setting to other blocks when Angelica's GLStateCaching is enabled.
To fight against this I wrote enableStandardItemLighting() without unused directional light setting, and cached ambient light setting in the new method to prevent leakage.