SRCH-368 remove legacy SERP code (#738)

* SRCH-243 SRCH-1525 SRCH-2109 remove legacy SERP code (#736)
- remove legacy views, helpers & click-tracking code
- remove "Compare Search Results" super admin feature
- remove advanced-firstgov logic
- remove deprecated or duplicated features
- remove legacy seed & fixtures
- remove legacy spec & feature helpers
- redirect video news search path to search path
- disable duplication check for specs

* SRCH-2315 remove mobile-fu gem & related logic (#740)
- replace custom "mobile" format with "html"
- remove remaining "force_mobile_format" logic
- remove deprecated parameters from permitted list
- remove or update tests
- remove or update VCR cassettes

* SRCH-2108 remove bcrypt-ruby gem (#741)

* SRCH-2314 remove legacy search classes (#747)

* SRCH-2106 remove legacy assets (#750)
- update asset-related gems

* SRCH-2111 remove additional legacy SERP code (#751)
- remove unused image assets and stylesheets
- removed unused cucumber helpers

* SRCH-2378 update addressable to 2.8.0 (#760)
- bundle update gems

* SRCH-2423 return assets used for affiliate type-ahead (#763)

.circleci/config.yml

@@ -5,7 +5,7 @@
 version: 2.1
 
 orbs:
-  ruby: circleci/[email protected].2
+  ruby: circleci/[email protected].4
 
 executors:
   test_executor:

.codeclimate.yml

@@ -19,6 +19,8 @@ plugins:
     enabled: true
   duplication:
     enabled: true
+    exclude_patterns:
+    - "spec/"
     config:
       languages:
       - ruby

Gemfile

@@ -8,15 +8,15 @@ gem 'rails-observers', '~> 0.1.5'
 gem 'responders', '~> 2.0'
 gem 'mysql2', '~> 0.4.4'
 gem 'curb', '~> 0.9.4'
-gem 'haml', '~> 5.0.4'
-gem 'will_paginate', '~> 3.1.6'
+gem 'haml', '~> 5.2.1'
+gem 'will_paginate', '~> 3.3.0'
 gem 'nokogiri', '~> 1.11.1'
-gem 'bcrypt-ruby', '~> 3.1.5', :require => 'bcrypt'
 gem 'authlogic', '~> 3.8.0'
 # Temporarily locking gem to specific ref. Newer versions include incompatible gems
 gem 'omniauth_login_dot_gov', git: 'https://github.com/18f/omniauth_login_dot_gov',
                               ref: '08ce9b5322efb2d82b2df3f6d774308c4028ee6c'
 gem 'omniauth-rails_csrf_protection', '~> 0.1.2'
+# Airbrake is deprecated: https://cm-jira.usa.gov/browse/SRCH-2249
 gem 'airbrake', '~> 7.1.1'
 gem 'redis', '~> 4.0.1'
 gem 'redis-namespace', '~> 1.6.0'
@@ -26,14 +26,14 @@ gem 'resque-priority', :git => 'https://github.com/GSA/resque-priority.git'
 gem 'resque-timeout', '~> 1.0.0'
 gem 'resque-lock-timeout', '~> 0.4.5'
 gem 'resque-scheduler', '~> 4.3.1'
+# Paperclip is deprecated: https://cm-jira.usa.gov/browse/SRCH-702
 gem 'paperclip', '~> 5.2.0'
 gem 'googlecharts', '~> 1.6.12'
 gem 'tweetstream', '~> 2.6.1' # no longer maintained?
 gem 'twitter', git: 'https://github.com/GSA/twitter.git', branch: '5-stable'
 gem 'flickraw', '~> 0.9.9'
 gem 'active_scaffold', '~> 3.5.0'
 gem 'active_scaffold_export', git: 'https://github.com/naaano/active_scaffold_export'
-gem 'mobile-fu', '~> 1.4.0' # deprecated - legacy SERP
 gem "recaptcha", '~> 4.6.3', :require => "recaptcha/rails"
 gem 'newrelic_rpm', '~> 5.0.0'
 gem 'american_date', '~> 1.1.1'
@@ -49,9 +49,9 @@ gem 'rash_alt', git: 'https://github.com/MothOnMars/rash_alt', ref: 'bbd107061fb
 gem 'geoip', '~> 1.6.3'
 gem 'htmlentities', '~> 4.3.4' # deprecated - only used in Google web search
 gem 'html_truncator', '~> 0.4.2'
-gem 'addressable', '~> 2.5.2'
+gem 'addressable', '~> 2.8.0'
 gem 'select2-rails', '~> 4.0.3'
-gem 'turbolinks', '~> 5.0.1'
+gem 'turbolinks', '~> 5.2.1'
 gem 'will_paginate-bootstrap', '~> 1.0.1'
 gem 'virtus', '~> 1.0.5'
 gem 'truncator', '~> 0.1.7'
@@ -64,6 +64,7 @@ gem 'github-markdown', '~> 0.6.9'
 gem 'google-api-client', '~> 0.19.1'
 gem 'iso8601', '~> 0.10.1'
 gem 'jbuilder', '~> 2.6.4'
+# sitelink_generator is deprecated: https://cm-jira.usa.gov/browse/SRCH-2172
 gem 'sitelink_generator', git: 'https://github.com/GSA/sitelink_generator', ref: '2f78cd142547a2a87e500266f1ef4eb5e281cc6b'
 gem 'typhoeus', '~> 1.3.0'
 gem 'activerecord-validate_unique_child_attribute',
@@ -74,6 +75,7 @@ gem 'grape', '~> 1.1'
 gem 'grape-entity', '~> 0.6.0'
 gem 'rack-cors', '~> 1.1.0', :require => 'rack/cors'
 gem 'hashie', '~> 3.3.0'
+# retry_block is unsupported - consider replacing with retriable
 gem 'retry_block', '~> 1.2.0'
 gem 'aws-sdk', '< 3.0'
 gem 'colorize', '~> 0.8.1'
@@ -96,8 +98,8 @@ gem 'retriable', '~> 3.1'
 gem 'cld3', '~> 3.2.3'
 
 # Assets-related gems
-gem 'coffee-rails', '~> 4.2.2'
-gem 'uglifier', '~> 4.1.2'
+gem 'coffee-rails', '~> 5.0.0'
+gem 'uglifier', '~> 4.2.0'
 gem 'less-rails-bootstrap', git: 'https://github.com/GSA/less-rails-bootstrap.git',
                             branch: 'master'
 gem 'compass-rails', '~> 3.1.0'