-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep for version 1 #1004
Prep for version 1 #1004
Conversation
@brockfanning thanks for starting this! We were just talking about taking on this work GSA/data.gov#1243 I'll push this to Federalist for preview and take a look. |
@adborden No problem. A couple updates:
|
@adborden @philipashlock Another update - we have included a bit more refactoring into the upcoming 1.0.0 release. The latest tag is 1.0.0-beta3. It will require some updates to this PR. I'll go ahead and rebase the PR to make those updates, unless you object. |
61d01e4
to
e7665f0
Compare
@adborden @philipashlock |
@brockfanning it looks like a git hiccup, try re-running your CI job. |
... spoke to soon,
And sure enough, I'm not seeing any /stats/reporting.json on the gh-pages branch of GSA/sdg-data-usa. I'm not sure who owns that repo, I don't even have write access. |
@adborden I think this needs another rebase. The test failures now are likely because this is a really a three-part pull request - see the links in the PR description. I'm not sure what the specifics are now for deployment workflows, but I suspect this PR will be tricky to test. In the meantime I'll try another rebase to keep it current. |
e7665f0
to
34500d1
Compare
Yeah, same error. Is it possible to add a configuration so that we can point to the updated branches? That way we can build and test without having to merge everything and 🤞 |
The challenge is that this PR of the data repository needs to be built and deployed. But obviously we don't want to merge that PR without testing. Do you know if there is any mechanism for deploying feature branches of the sdg-data-usa repository? Not sure if sdg-data-usa is wired into the Federalist stuff or not. If not, I could see if I can deploy a build of my branch using my fork. Once we have a build of that PR deployed somewhere, then yes we can update this PR to point there, at which point it should pass tests. |
Closing as outdated |
This PR includes:
This will likely fail automated tests, because it depends on changes to the translations and data repos: