-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #23
Open
princeofdarkness76
wants to merge
59
commits into
GPGTools:build-refactoring
Choose a base branch
from
princeofdarkness76:dev
base: build-refactoring
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev #23
princeofdarkness76
wants to merge
59
commits into
GPGTools:build-refactoring
from
princeofdarkness76:dev
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use authorization functions to get privileges.
[#140 state:fixed assigned:mento]
…tate:fixed] - Using self creates a retain cycle which causes the LPXTTask to never be dealloced - Use __block to break the retain cycle.
…stablished [#143 state:fixed] - Store the errors which are created in different instance variables, so there's no chance one is overwritten. - Throw the most appropriate error.
- If the reply block is not invoked, the xpc method could wait forever and stall.
[GPGTools#14 state:fixed assigned:mento] [#38 state:fixed assigned:mento] [#145 state:fixed assigned:mento]
…a passphrase is in cache [#147 state:fixed] - Before the socket was not closed, if the passphrase was found in the gpg-agent's cache. After a while the available file descriptors where exhausted and many IO operations using gpg-agent would fail. - Adds the GPGSocketCloseTest unit test which fails if the socket connections are not properly closed.
[#146 state:fixed assigned:mento]
GPGFileStream uses a cache to speed up single byte reading.
GPGPacket is split in multiple sub-classes. GPGPacketParser is used to get packets out of a GPGStream. keysInExportedData adjusted. Version set to 0.6.
Unit test for GPGUnArmor added.
This should prevent dylib hijacking.
[#150 state:fixed assigned:mento]
[#64 state:fixed assigned:mento milestone:0.7]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#64 state:fixed assigned:mento milestone:0.7]