[3주차] 기본 과제 제출 (#7) #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditoo-land
reviewed
May 7, 2023
Comment on lines
+16
to
+17
| */ | ||
| @ResponseStatus(HttpStatus.BAD_REQUEST) |
There was a problem hiding this comment.
ErrorStatus에서 Bad Request를 보내주는 것으로 보입니다. 따라서 위에 어노테이션으로 두지 않아도 괜찮습니다:)
ditoo-land
reviewed
May 7, 2023
Comment on lines
+12
to
+13
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| public class User { |
ditoo-land
reviewed
May 7, 2023
Comment on lines
+12
to
+31
| /* | ||
| BAD_REQUEST | ||
| */ | ||
| VALIDATION_EXCEPTION(HttpStatus.BAD_REQUEST, "잘못된 요청입니다."), | ||
| VALIDATION_REQUEST_MISSING_EXCEPTION(HttpStatus.BAD_REQUEST, "요청값이 입력되지 않았습니다."), | ||
|
|
||
|
|
||
| /* | ||
| CONFLICT | ||
| */ | ||
| CONFLICT_EMAIL_EXCEPTION(HttpStatus.CONFLICT, "이미 등록된 이메일입니다."), | ||
| CONFLICT_NICKNAME_EXCEPTION(HttpStatus.CONFLICT, "이미 등록된 닉네임입니다."), | ||
|
|
||
| /* | ||
| SERVER_ERROR | ||
| */ | ||
| INTERNAL_SERVER_ERROR(HttpStatus.INTERNAL_SERVER_ERROR, "예상치 못한 서버 에러가 발생했습니다."), | ||
| BAD_GATEWAY_EXCEPTION(HttpStatus.BAD_GATEWAY, "일시적인 에러가 발생하였습니다.\n잠시 후 다시 시도해주세요!"), | ||
| SERVICE_UNAVAILABLE_EXCEPTION(HttpStatus.SERVICE_UNAVAILABLE, "현재 점검 중입니다.\n잠시 후 다시 시도해주세요!"), | ||
| ; |
ditoo-land
reviewed
May 7, 2023
Comment on lines
+18
to
+27
| @Transactional | ||
| public UserResponseDto create(UserRequestDto request) { | ||
| User user = User.builder() | ||
| .email(request.getEmail()) | ||
| .nickname(request.getNickname()) | ||
| .password(request.getPassword()) | ||
| .build(); | ||
| userRepository.save(user); | ||
| return UserResponseDto.of(user.getId(), user.getNickname()); | ||
| } |
hyesuuou
reviewed
May 7, 2023
| private final String nickname; | ||
|
|
||
| @NotBlank | ||
| @Pattern(regexp="(?=.*[0-9])(?=.*[a-zA-Z])(?=.*\\W)(?=\\S+$).{8,20}",message = "비밀번호는 영문 대,소문자와 숫자, 특수기호가 적어도 1개 이상씩 포함된 8자 ~ 20자의 비밀번호여야 합니다.") |
hyesuuou
reviewed
May 7, 2023
| import sopt.org.ThirdSeminar.exception.SuccessStatus; | ||
|
|
||
| @Getter | ||
| @RequiredArgsConstructor(access = AccessLevel.PRIVATE) |
hansh0101
reviewed
May 10, 2023
| @@ -0,0 +1,37 @@ | |||
| HELP.md | |||
| testImplementation 'org.springframework.boot:spring-boot-starter-test' | ||
|
|
||
| implementation 'org.springframework.boot:spring-boot-starter-data-jpa' | ||
| // mysql --version |
Comment on lines
+6
to
+7
| @SpringBootApplication | ||
| public class ThirdSeminarApplication { |
Comment on lines
+32
to
+53
| // | ||
| //@Getter | ||
| //@RequiredArgsConstructor(access = AccessLevel.PRIVATE) | ||
| //@AllArgsConstructor(access = AccessLevel.PRIVATE) | ||
| //public class ApiResponseDto<T> { | ||
| // | ||
| // private final int code; | ||
| // private final String message; | ||
| // private T data; | ||
| // | ||
| // public static ApiResponseDto success(SuccessStatus successStatus) { | ||
| // return new ApiResponseDto<>(successStatus.getHttpStatus().value(), successStatus.getMessage()); | ||
| // } | ||
| // | ||
| // public static <T> ApiResponseDto<T> success(SuccessStatus successStatus, T data) { | ||
| // return new ApiResponseDto<T>(successStatus.getHttpStatus().value(), successStatus.getMessage(), data); | ||
| // } | ||
| // | ||
| // public static ApiResponseDto error(ErrorStatus errorStatus) { | ||
| // return new ApiResponseDto<>(errorStatus.getHttpStatus().value(), errorStatus.getMessage()); | ||
| // } | ||
| //} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SERVER PR
closed #7
미 안 !!!! 피알나중에쓸게.. ㅜ.ㅜ
🐕 과제 구현 명세
✅ 기본 과제
✅ 심화 과제
🐥 이런 점이 새로웠어요 / 어려웠어요