Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more testing of the data access methods and some fixing #838

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jgrewe
Copy link
Member

@jgrewe jgrewe commented May 25, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #838 (0f41b27) into master (8ef0d94) will decrease coverage by 0.02%.
The diff coverage is 95.12%.

@@            Coverage Diff             @@
##           master     #838      +/-   ##
==========================================
- Coverage   95.71%   95.68%   -0.03%     
==========================================
  Files         201      201              
  Lines       13691    13706      +15     
==========================================
+ Hits        13104    13115      +11     
- Misses        587      591       +4     
Impacted Files Coverage Δ
include/nix/DataView.hpp 88.88% <ø> (+11.11%) ⬆️
src/util/dataAccess.cpp 88.69% <87.50%> (-0.90%) ⬇️
src/Dimensions.cpp 92.71% <100.00%> (ø)
test/BaseTestDataAccess.cpp 100.00% <100.00%> (ø)
test/BaseTestDimension.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef0d94...0f41b27. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant