Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adaptations for RangeDimension indexOf methods #819

Merged
merged 27 commits into from
Aug 19, 2020
Merged

adaptations for RangeDimension indexOf methods #819

merged 27 commits into from
Aug 19, 2020

Commits on Jul 28, 2020

  1. [dims] improve docstring of rd::indexOf

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    db9d121 View commit details
    Browse the repository at this point in the history

  2. [dimension] adds enum classes to be used in RangeDim index matching

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    96dc583 View commit details
    Browse the repository at this point in the history

  3. [dimension] new method to check if a position is in range of a RangeDim 

    along with respective tests
    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    b0301a2 View commit details
    Browse the repository at this point in the history

  4. [dimension] deprecate old indexOf adapt test to expected exceptions

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    4038cda View commit details
    Browse the repository at this point in the history

  5. [dimension] new version of internal getIndex function

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    72241e0 View commit details
    Browse the repository at this point in the history

  6. [dimension] add new overload of indexOf ... 

    this overload uses the PositionMatch enum. Added tests for it.
    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    6aa7bb1 View commit details
    Browse the repository at this point in the history

  7. [dimension] add enum to control if ranges should be in- or exclusive

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    574eb05 View commit details
    Browse the repository at this point in the history

  8. [dimension] deprecate indexOf for ranges ... 

    adapt the method implementation to use new getIndex function
    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    f78fb34 View commit details
    Browse the repository at this point in the history

  9. [dimension] adds overload for indexOf(start, end, ... 

    which now takes takes (optionally) the ticks, and the RangeMatch arg
to control inclusive or exclusive range matching
    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    a86de24 View commit details
    Browse the repository at this point in the history

  10. [dimension] changes indexOf(vector starts, vector ends, ... 

    to use the optional variants of indexOf, invalid ranges are "silently"
ignored
    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    d2a31a8 View commit details
    Browse the repository at this point in the history

  11. [dimension/indexOf] passes ticks as an rval ref to avoid copying

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    3b02fe7 View commit details
    Browse the repository at this point in the history

  12. [dimension/indexof] adds a strict flag to index of function of RangeD… 

    …im ...

This is to define whether invalid start - end ranges are silently ignored
or in an exception should be thrown
    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    e187c31 View commit details
    Browse the repository at this point in the history

  13. [dimension] indexOf add overload which returns vector of optionals

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    1abe18d View commit details
    Browse the repository at this point in the history

  14. [dimension] indexOf add strict flag and deprecate it... 

    to control whether invalid ranges lead to an exception,
    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    33c0bf6 View commit details
    Browse the repository at this point in the history

  15. [dimension/sampled] changes to indexOf functions ... 

    positions less than offset now directly lead to an OutOfBounds error,
add an overload to simplify function calls, adapt the tests accordingly
    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    e213de4 View commit details
    Browse the repository at this point in the history

  16. [dimensions/sampled] catch a few corner cases in indexOf

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    e76a49c View commit details
    Browse the repository at this point in the history

  17. [dimension/sampled] overloads and deprecations of indexOf methods

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    ed21643 View commit details
    Browse the repository at this point in the history

  18. [dimension/SetDim] add indexOf method and respective tests

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    5829e02 View commit details
    Browse the repository at this point in the history

  19. [dimension/Set] add method for getting the indices of a range

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    36ef762 View commit details
    Browse the repository at this point in the history

  20. [dimensions/sampled] add test case, simplify range validity check

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    c6e1474 View commit details
    Browse the repository at this point in the history

  21. [dimension/set] add indexOf overlaod for vectors of ranges ... 

    plus respective tests
    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    3f67acd View commit details
    Browse the repository at this point in the history

  22. [dataAccess] overhaul of positionToIndex methods ... 

    overloads for optionals that support range and position matching,
respective tests
    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    76b6688 View commit details
    Browse the repository at this point in the history

  23. [dataAccess] support RangeMatch selections I

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    a6b5e34 View commit details
    Browse the repository at this point in the history

  24. [dataAccess] support RangeMatch selections II

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    b75544a View commit details
    Browse the repository at this point in the history

  25. [testDataAccess/dataSlice] tests for exclusive ranges

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    db069e0 View commit details
    Browse the repository at this point in the history

  26. [dimensions] remove rvalue reference, just copy

    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    7d55c58 View commit details
    Browse the repository at this point in the history

  27. [dataAccess] start > end leads to an invalied range, or even an excep… 

    …tion
    @jgrewe
    jgrewe committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    ec46176 View commit details
    Browse the repository at this point in the history