[dimensions] remove rvalue reference, just copy

G-Node · May 23, 2020 · 7d9c9d6 · 7d9c9d6
1 parent f5c549a
commit 7d9c9d6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/include/nix/Dimensions.hpp b/include/nix/Dimensions.hpp
@@ -847,8 +847,7 @@ class NIXAPI RangeDimension : public base::ImplContainer<base::IRangeDimension>
      * @return           Start and end indices returned in a boost::optional<std::pair>
      *                   which is invalid if out of range.
      */
-    boost::optional<std::pair<ndsize_t, ndsize_t>> indexOf(double start, double end,
-                                                           std::vector<double> &&ticks,
+    boost::optional<std::pair<ndsize_t, ndsize_t>> indexOf(double start, double end, std::vector<double> ticks,
                                                            RangeMatch match = RangeMatch::Inclusive) const;
 
 

diff --git a/src/Dimensions.cpp b/src/Dimensions.cpp
@@ -625,7 +625,7 @@ boost::optional<ndsize_t> RangeDimension::indexOf(const double position, Positio
 
 
 boost::optional<std::pair<ndsize_t, ndsize_t>> RangeDimension::indexOf(double start, double end,
-                                                                       std::vector<double> &&ticks,
+                                                                       std::vector<double> ticks,
                                                                        RangeMatch match) const {
     if (ticks.size() == 0) {
         ticks = this->ticks();
@@ -698,7 +698,7 @@ std::vector<boost::optional<std::pair<ndsize_t, ndsize_t>>> RangeDimension::inde
     vector<double> ticks = this->ticks();
     for (size_t i = 0; i < start_positions.size(); ++i) {
         boost::optional<std::pair<ndsize_t, ndsize_t>> range;
-        range = this->indexOf(start_positions[i], end_positions[i], std::move(ticks), match);
+        range = this->indexOf(start_positions[i], end_positions[i], ticks, match);
         indices.push_back(range);
     }
     return indices;