Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation tracks data resource #701

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Animation tracks data resource #701

merged 6 commits into from
Nov 8, 2024

Conversation

mrDIMAS
Copy link
Member

@mrDIMAS mrDIMAS commented Nov 8, 2024

This PR splits animation in two parts:

  1. The animation itself, that holds the required runtime information such as playback time, time slice, track bindings etc.
  2. The animation tracks data resource, that holds (mostly) immutable data of animation tracks. This resource could be shared across multiple animations to reduce memory consumption.

@mrDIMAS
initial attempt to decouple animation tracks data into a shared resource
3521280 
- significantly reduces memory constumption when cloning animations, since it does not need to clone the tracks anymore.
- animation resource can be shared across multiple animations using the same tracks
- significantly speeds up instantiation of animation player scene node
- the editor is still broken and requires proper fixes
- no backward compatibility yet
@mrDIMAS
fixed node handle mapping for hash maps
68ce2e0
@mrDIMAS
backward compatibility for existing animations
0ad8a42 
- creates an embedded animation tracks data resource
@mrDIMAS
build fix for editor + minor api improvements
ca21409
@mrDIMAS
docs for new animation entities
e4c88c3
@mrDIMAS
fixed code examples
91dd22c
@mrDIMAS mrDIMAS merged commit 558f74f into master Nov 8, 2024
20 of 21 checks passed
@mrDIMAS mrDIMAS deleted the animation_resource branch November 8, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrDIMAS