No Hitbox (Marker) Flag #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BisUmTo
commented
Nov 5, 2022
| @@ -15,6 +16,9 @@ public interface ArmorStandAccessor { | |||
| @Accessor | |||
| NonNullList<ItemStack> getHandItems(); | |||
|
|
|||
| @Invoker("getDimensionsMarker") | |||
| EntityDimensions getArmorstandDimensions(boolean marker); | |||
There was a problem hiding this comment.
Maybe it is better to use the "call" prefix to be consistent... 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature changes
Added a flag to remove the Hitbox from statue. (A.K.A. Marker NBT flag)
This allows to place blocks inside the statue, disable pistons pushing it, (also removing interagibility and gravity).
Dev info
To allow the interaction while sneaking, I redirected some "ProjectileUtil" static function used only during look-tracing.
I didn't test the forge version 😥