Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for specific error message. #6758

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes for specific error message. #6758

wants to merge 1 commit into from

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Nov 25, 2024

The added test case was emitting a wrong/confusing error message, because a for loop only gets type-checked in its desugared form, as a while loop.

The error message was A while loop's loop body cannot implicitly return a value. Try assigning it to a mutable variable declared outside of the loop instead.

Corrected to: A for loop's loop body cannot implicitly return a value. Try assigning it to a mutable variable declared outside of the loop instead.

Fixes #6395

Description

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

The added test case was emitting a wrong/confusing error message, because a for loop only gets
type-checked in its desugared form, as a while loop.

The error message was `A while loop's loop body cannot implicitly return a value.
Try assigning it to a mutable variable declared outside of the loop instead.`

Corrected to: `A for loop's loop body cannot implicitly return a value.
Try assigning it to a mutable variable declared outside of the loop instead.`
@esdrubal esdrubal added compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen audit-report Related to the audit report labels Nov 25, 2024
@esdrubal esdrubal self-assigned this Nov 25, 2024
@esdrubal esdrubal changed the title Fixes for specific error message. Fixes for specific error message. Nov 25, 2024
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #6758 will not alter performance

Comparing esdrubal/6395 (f4d9fba) with master (64d1c6e)

Summary

✅ 22 untouched benchmarks

@esdrubal esdrubal marked this pull request as ready for review November 26, 2024 10:10
@esdrubal esdrubal requested a review from a team as a code owner November 26, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit-report Related to the audit report compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Error Message Emitted
2 participants