Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for aliased import for encoding v1 #6628

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Oct 9, 2024

Description

Fixes #6569

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Copy link

codspeed-hq bot commented Oct 9, 2024

CodSpeed Performance Report

Merging #6628 will degrade performances by 38.69%

Comparing xunilrj/encoding-auto-impl-aliased-import (a7ec3b0) with master (278bb8c)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master xunilrj/encoding-auto-impl-aliased-import Change
goto_definition 1.7 ms 2.7 ms -38.69%

@xunilrj xunilrj force-pushed the xunilrj/encoding-auto-impl-aliased-import branch from afb1729 to 2d5193d Compare November 14, 2024 12:12
@xunilrj xunilrj marked this pull request as ready for review November 14, 2024 14:31
@xunilrj xunilrj requested a review from a team as a code owner November 14, 2024 14:31
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ugly but so was the original.
I sure hope we can get proper canonical paths soon and fixup the alias implementation.

@IGI-111 IGI-111 requested a review from a team November 15, 2024 03:23
@xunilrj xunilrj force-pushed the xunilrj/encoding-auto-impl-aliased-import branch from c5bec08 to a7ec3b0 Compare November 22, 2024 11:05
@xunilrj xunilrj merged commit 64d1c6e into master Nov 22, 2024
40 checks passed
@xunilrj xunilrj deleted the xunilrj/encoding-auto-impl-aliased-import branch November 22, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aliases can make compilation fail with "missing core dependencies`" & Could not generate entry method
4 participants