Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't contrain type arguments of StorageMap #6034

Merged
merged 2 commits into from
May 21, 2024
Merged

Don't contrain type arguments of StorageMap #6034

merged 2 commits into from
May 21, 2024

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented May 20, 2024 •
edited
Loading

Description

This allows instantiation of StorageMap without needing to import the Hash trait.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111 IGI-111 force-pushed the IGI-111/no-constrain-hash branch from 2a01049 to 33ffd75 Compare May 20, 2024 08:44
@IGI-111
Don't contrain type arguments of StorageMap
84c1aa8 
This allows instantiation of StorageMap without needing to import the
Hash trait.
@IGI-111 IGI-111 force-pushed the IGI-111/no-constrain-hash branch from 33ffd75 to 84c1aa8 Compare May 20, 2024 08:45
@IGI-111 IGI-111 requested review from bitzoic and a team May 20, 2024 09:08
@IGI-111 IGI-111 self-assigned this May 20, 2024
@IGI-111 IGI-111 marked this pull request as ready for review May 20, 2024 09:09
bitzoic
bitzoic approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@bitzoic bitzoic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@JoshuaBatty JoshuaBatty enabled auto-merge (squash) May 21, 2024 02:20
@JoshuaBatty JoshuaBatty merged commit 8a0a722 into master May 21, 2024
35 checks passed
@JoshuaBatty JoshuaBatty deleted the IGI-111/no-constrain-hash branch May 21, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitzoic bitzoic bitzoic approved these changes

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

Assignees

@IGI-111 IGI-111

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IGI-111 @JoshuaBatty @bitzoic