Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sophie/forc doc primitives 2 #6033

Closed
wants to merge 5 commits into from
Closed

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented May 19, 2024

Description

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel closed this May 19, 2024
@sdankel sdankel deleted the sophie/forc-doc-primitives-2 branch May 19, 2024 21:54
Copy link

Benchmark for 05a6fc2

Click to view benchmark
Test Base PR %
code_action 5.3±0.16ms 5.2±0.11ms -1.89%
code_lens 284.2±9.36ns 284.0±10.94ns -0.07%
compile 3.0±0.04s 2.8±0.03s -6.67%
completion 4.6±0.09ms 4.6±0.09ms 0.00%
did_change_with_caching 2.9±0.05s 2.7±0.03s -6.90%
document_symbol 1001.9±39.55µs 966.4±14.75µs -3.54%
format 74.9±0.73ms 72.7±0.74ms -2.94%
goto_definition 364.0±4.06µs 363.5±3.71µs -0.14%
highlight 8.8±0.14ms 8.8±0.13ms 0.00%
hover 488.9±6.36µs 490.0±7.13µs +0.22%
idents_at_position 122.2±0.29µs 122.9±1.34µs +0.57%
inlay_hints 655.3±27.20µs 653.2±29.28µs -0.32%
on_enter 467.9±11.93ns 470.2±13.12ns +0.49%
parent_decl_at_position 3.6±0.04ms 3.6±0.02ms 0.00%
prepare_rename 365.3±6.08µs 364.9±6.51µs -0.11%
rename 9.4±0.24ms 9.2±0.04ms -2.13%
semantic_tokens 987.1±24.80µs 980.9±11.69µs -0.63%
token_at_position 365.3±3.10µs 361.0±2.12µs -1.18%
tokens_at_position 3.6±0.02ms 3.6±0.04ms 0.00%
tokens_for_file 417.7±3.58µs 410.1±2.29µs -1.82%
traverse 40.6±0.84ms 38.7±0.47ms -4.68%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant