Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vault standard examples #121

Merged
merged 6 commits into from
Jul 8, 2024
Merged

Fix vault standard examples #121

merged 6 commits into from
Jul 8, 2024

Conversation

SwayStar123
Copy link
Member

@SwayStar123 SwayStar123 commented Jul 2, 2024

Type of change

  • Bug fix

Changes

The examples which used the Vault struct in the vault examples did not initialize a new asset with an empty vault when the vault is deposited to for the first time, this will result in all deposits failing.

Notes

The bug originates because in prior versions of Sway, reads could not fail and would return 0'ed out values for all struct fields, leading to a oversight when updating versions

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.
  • I have updated the changelog to reflect the changes on this PR.

@SwayStar123 SwayStar123 marked this pull request as ready for review July 2, 2024 15:09
@SwayStar123 SwayStar123 requested a review from a team as a code owner July 2, 2024 15:09
@SwayStar123 SwayStar123 self-assigned this Jul 2, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@SwayStar123 SwayStar123 requested a review from bitzoic July 8, 2024 10:58
bitzoic
bitzoic previously approved these changes Jul 8, 2024
@SwayStar123 SwayStar123 requested a review from bitzoic July 8, 2024 11:07
@bitzoic bitzoic added Bug Something isn't working Documentation Improvements or additions to documentation SRC-6 Label used to filter for the standard issue labels Jul 8, 2024
@bitzoic bitzoic requested a review from a team July 8, 2024 11:07
@bitzoic bitzoic requested a review from a team July 8, 2024 11:08
@SwayStar123 SwayStar123 merged commit b0e99a6 into master Jul 8, 2024
6 checks passed
@bitzoic bitzoic mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Documentation Improvements or additions to documentation SRC-6 Label used to filter for the standard issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants