-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement low_level_call into the multisig #716
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Braqzen <[email protected]>
…into Updated-CALL
Comments addressed, @Braqzen |
Braqzen
reviewed
Aug 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niceu, almosto thereo my friendo
multisig-wallet/project/contracts/multisig-contract/tests/utils/setup.rs
Outdated
Show resolved
Hide resolved
multisig-wallet/project/contracts/multisig-contract/src/main.sw
Outdated
Show resolved
Hide resolved
Braqzen
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
App: Multisig
Label used to filter for the app issue
New Feature
New addition that does not currently exist
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Changes
The following changes have been made:
transfer
andexecute_transaction
have been merged into a single function:execute_transaction
compute_hash
has replaced the separate hash functions.Notes
functions::info::compute_hash::gets_call_hash
has been written, but is ignored with the following reason:Related Issues
Closes #22
Closes #717
Closes #718
Implementing SRC-2 Closes #424