Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement low_level_call into the multisig #716

Merged
merged 68 commits into from
Aug 14, 2023
Merged

Implement low_level_call into the multisig #716

merged 68 commits into from
Aug 14, 2023

Conversation

K1-R1
Copy link
Member

@K1-R1 K1-R1 commented Aug 2, 2023

Type of change

  • New feature

Changes

The following changes have been made:

  • transfer and execute_transaction have been merged into a single function: execute_transaction
  • SRC-2 has been implemented
  • A single hash function compute_hash has replaced the separate hash functions.
  • The use of arbitrary bytes in hash functions has been removed, more detail available in notes below.
  • pub(crate)

Notes

  • Arbitrary bytes in hash functions have been removed as they served to add additional entropy; however this is not necessary as knowing the hash does not create a vulnerability, the hash must still be signed over by a multisig user.
  • The test functions::info::compute_hash::gets_call_hash has been written, but is ignored with the following reason:

Encoding of nested structs with Bytes fields in the RustSDK doesn't match the encoding in Sway. This is not an issue for the use of compute_hash when making a contract call; as the user would not be creating the hash in the SDK

Related Issues

Closes #22
Closes #717
Closes #718

Implementing SRC-2 Closes #424

@K1-R1 K1-R1 requested review from Braqzen and a team August 7, 2023 14:22
@K1-R1
Copy link
Member Author

K1-R1 commented Aug 11, 2023

Comments addressed, @Braqzen

Copy link
Contributor

@Braqzen Braqzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceu, almosto thereo my friendo

@K1-R1 K1-R1 requested a review from Braqzen August 14, 2023 14:03
@K1-R1 K1-R1 enabled auto-merge August 14, 2023 15:47
@K1-R1 K1-R1 merged commit 2509762 into master Aug 14, 2023
18 checks passed
@K1-R1 K1-R1 deleted the Updated-CALL branch August 14, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: Multisig Label used to filter for the app issue New Feature New addition that does not currently exist
Projects
None yet
2 participants