-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add NFTs tab #1762
base: master
Are you sure you want to change the base?
feat: add NFTs tab #1762
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we start with all collections expanded? except by the "Others" , that one can be collapsed
packages/app/src/systems/Account/components/BalanceAssets/BalanceAssets.tsx
Outdated
Show resolved
Hide resolved
.sort((a, b) => { | ||
if (a.name === UNKNOWN_COLLECTION_TITLE) return 1; | ||
if (b.name === UNKNOWN_COLLECTION_TITLE) return -1; | ||
return 0; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we sort by name also?
- A
- B
- Z
- Others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you talking about collection names or NFT names?
If it's about NFT names, it's already sorting by name
:
If you're talking about collection names, I'd like to apply but I didn't because in the explorer it's also not sorting.
If you compare our listing with explorer right now, they're identical.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- in the black theme I can't see any separator between the collections
- I think the collection name can be a little bit bigger (in your video it looks bigger than when I run locally), did you change it after recording?
|
FE-1087
Screen.Recording.2025-01-09.at.17.08.04.mov