Skip to content

Commit

Permalink
refactor(e2e-assets): update end-to-end test configurations and remov…
Browse files Browse the repository at this point in the history
…e obsolete asset tests
  • Loading branch information
nelitow committed Dec 12, 2024
1 parent 66ba10f commit 5aa2b8d
Show file tree
Hide file tree
Showing 6 changed files with 42 additions and 53 deletions.
1 change: 0 additions & 1 deletion .github/workflows/pr-tests-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ jobs:
timeout-minutes: 15
env:
NODE_ENV: test
READONLY_TESTNET_ASSETS_VIEW: ${{ secrets.READONLY_TESTNET_ASSETS_VIEW }}

- uses: actions/upload-artifact@v4
if: always()
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"test:e2e": "NODE_ENV=test pnpm build:crx && playwright test --config=packages/app/playwright.config.ts --project=chromium",
"test:e2e:beta": "NODE_ENV=test pnpm build:crx && playwright test --config=packages/app/playwright.config.ts --project=chrome-beta",
"test:e2e:crx-lock": "NODE_ENV=test pnpm build:crx && playwright test --config=packages/app/playwright.crx-lock.config.ts",
"test:e2e:assets": "NODE_ENV=test pnpm playwright test --config=packages/e2e-assets/playwright.config.ts",
"test:e2e:contracts": "NODE_ENV=test pnpm build:crx && pnpm --filter=@fuel-wallet/e2e-contract-tests test:e2e",
"test:appfile": "pnpm --filter=fuels-wallet test --",
"ts:check": "turbo run ts:check",
Expand Down
45 changes: 0 additions & 45 deletions packages/app/playwright/crx/assets.test.ts

This file was deleted.

4 changes: 1 addition & 3 deletions packages/e2e-assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
"version": "0.43.0",
"type": "module",
"database": "23",
"scripts": {
"dev:crx": "pnpm --workspace-root dev:crx"
},
"scripts": {},
"dependencies": {},
"devDependencies": {
"@playwright/test": "1.46.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-assets/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default defineConfig({
['html', { outputFolder: './playwright-html/' }],
],
webServer: {
command: 'NODE_ENV=test pnpm dev:crx',
command: 'NODE_ENV=test pnpm -w run dev:crx',
reuseExistingServer: true,
timeout: 20000,
url: `http://localhost:${PORT}`,
Expand Down
42 changes: 39 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 5aa2b8d

Please sign in to comment.