test: close pages so the auto lock run

FuelLabs · Dec 11, 2024 · 2cbe94e · 2cbe94e
1 parent 01bc0e3
commit 2cbe94e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 16 deletions.
diff --git a/.github/workflows/pr-tests-e2e-crx-lock.yml b/.github/workflows/pr-tests-e2e-crx-lock.yml
@@ -31,13 +31,6 @@ jobs:
       - name: Generate .env
         run: cp packages/app/.env.example packages/app/.env
 
-      - name: Build Application
-        run: pnpm build:app
-        env:
-          ## increase node.js m memory limit for building
-          ## with sourcemaps
-          NODE_OPTIONS: "--max-old-space-size=4096"
-
       - uses: ./.github/actions/setup-playwright
 
       - name: Run E2E Tests

diff --git a/.github/workflows/pr-tests-e2e.yml b/.github/workflows/pr-tests-e2e.yml
@@ -31,13 +31,6 @@ jobs:
       - name: Generate .env
         run: cp packages/app/.env.example packages/app/.env
 
-      - name: Build Application
-        run: pnpm build:app
-        env:
-          ## increase node.js m memory limit for building
-          ## with sourcemaps
-          NODE_OPTIONS: "--max-old-space-size=4096"
-
       - uses: ./.github/actions/setup-playwright
 
       - name: Run E2E Tests

diff --git a/packages/app/playwright/crx/lock.test.ts b/packages/app/playwright/crx/lock.test.ts
@@ -97,7 +97,10 @@ test.describe('Lock FuelWallet after inactivity', () => {
 
       /** Account created */
       await hasText(page, /Wallet created successfully/i, 0, 15000);
-      await page.close();
+
+      for (const page of pages) {
+        await page.close();
+      }
     });
 
     const popupPage = await test.step('Open wallet', async () => {
@@ -114,7 +117,10 @@ test.describe('Lock FuelWallet after inactivity', () => {
     });
 
     await test.step('Resume auto-lock timer after closing wallet', async () => {
-      await popupPage.close();
+      const pages = context.pages();
+      for (const page of pages) {
+        await page.close();
+      }
       const page = await context.newPage();
       await page.waitForTimeout(65_000);
       await page.goto(`chrome-extension://${extensionId}/popup.html`);