feat: auto-detect package manager in create fuels
#3503
+45
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This PR is published in NPM with version 0.0.0-pr-3503-20241226031927 |
CodSpeed Performance ReportMerging #3503 will degrade performances by 23.41%Comparing Summary
Benchmarks breakdown
|
Dhaiwat10
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
|
Coverage Report:
Changed Files:
|
danielbate
reviewed
Dec 26, 2024
| let packageManager: PackageManager | undefined = cliChosenPackageManagerSelected[0]; | ||
| if (cliChosenPackageManagerSelected.length > 1) { | ||
| warn('More than one package manager was selected.'); | ||
| if (userAgent.startsWith('pnpm')) { |
There was a problem hiding this comment.
Nit, please store package manager strings as constants
| } | ||
|
|
There was a problem hiding this comment.
console.warn here if the package users package manager is not supported and we default to npm?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create fuels#3488Release notes
In this release, we:
create fuelsSummary
create fuelsnow auto-detects the user's package manger. eg.bun create fuelswill now usebunto install dependencies.Breaking Changes
These package manager flags have been removed since they are not needed anymore:
--bun,--pnpm,--npmBefore
After
Checklist