Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added onBeforeSend hook to the connector interface #3487

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

petertonysmith94
Copy link
Contributor

Release notes

In this release, we:

  • Added onBeforeSend to the connector interface to allow for mutation of the transaction in the wallet.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2024 3:18am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2024 3:18am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2024 3:18am

@github-actions github-actions bot added the chore Issue is a chore label Dec 16, 2024
@petertonysmith94 petertonysmith94 changed the title chore: added feat: added onBeforeSend hook to the connector interface Dec 16, 2024
@github-actions github-actions bot added the feat Issue is a feature label Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

This PR is published in NPM with version 0.0.0-pr-3487-20241221031423

@maschad maschad changed the title feat: added onBeforeSend hook to the connector interface feat: added onBeforeSend hook to the connector interface Dec 16, 2024
Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #3487 will degrade performances by 50.66%

Comparing ps/chore/added-on-before-send-hook (6f17863) with master (41c72fb)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master ps/chore/added-on-before-send-hook Change
should successfully conduct a custom transfer between wallets (x20 times) 50.3 ms 101.9 ms -50.66%

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.33%(+0%) 69.81%(-0.03%) 74.2%(+0%) 76.34%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 78.82%
(+0%)
64%
(+0.49%)
80%
(+0%)
78.61%
(+0%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)
76.71%
(-1.37%)
84%
(+0%)
88.81%
(+0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants