Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Vitest matcher integration #3477

Merged

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Dec 13, 2024

Summary

  • Allowed a user to pass through the vitest.expect parameter to setupTestMatchers

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 self-assigned this Dec 13, 2024
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:13pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:13pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:13pm

@petertonysmith94 petertonysmith94 changed the title Ps/fix/allow vitest matchers to be used external fix: Vitest matcher integration Dec 13, 2024
@github-actions github-actions bot added the bug Issue is a bug label Dec 13, 2024
Copy link
Contributor

This PR is published in NPM with version 0.0.0-pr-3477-20241213154445

Copy link

codspeed-hq bot commented Dec 13, 2024

CodSpeed Performance Report

Merging #3477 will degrade performances by 17.43%

Comparing ps/fix/allow-vitest-matchers-to-be-used-external (50209a8) with master (efdf9a1)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master ps/fix/allow-vitest-matchers-to-be-used-external Change
should successfully transfer a single asset between wallets (x20 times) 57.8 ms 70 ms -17.43%

nedsalk
nedsalk previously approved these changes Dec 13, 2024
arboleya
arboleya previously approved these changes Dec 13, 2024
@petertonysmith94 petertonysmith94 dismissed stale reviews from arboleya and nedsalk via ecfdb01 December 13, 2024 16:00
arboleya
arboleya previously approved these changes Dec 13, 2024
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.33%(+0%) 69.84%(+0%) 74.2%(+0%) 76.34%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit 0970bc4 into master Dec 13, 2024
24 of 25 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/fix/allow-vitest-matchers-to-be-used-external branch December 13, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants