-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: specify versions in create fuels
toolchain file
#3475
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR is published in NPM with version 0.0.0-pr-3475-20241212204104 |
CodSpeed Performance ReportMerging #3475 will improve performances by 53.33%Comparing Summary
Benchmarks breakdown
|
Dhaiwat10
changed the title
fix: use
fix: specify versions in Dec 12, 2024
latest
toolchain channel for create fuels
create fuels
toolchain file
Dhaiwat10
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
December 12, 2024 20:42
arboleya
reviewed
Dec 13, 2024
danielbate
previously approved these changes
Dec 13, 2024
arboleya
previously approved these changes
Dec 13, 2024
danielbate
approved these changes
Dec 13, 2024
arboleya
approved these changes
Dec 13, 2024
petertonysmith94
approved these changes
Dec 13, 2024
Coverage Report:
Changed Files:Coverage values did not change👌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the 'deploying to testnet' guide not working as expected for new users by specifying versions for
forc
andfuel-core
in the toolchain files used bycreate fuels
projects. This fixes this error for users with freshfuelup
installations, and also people who may have never installed or used thetestnet
toolchain channel:This change fixes the problem because the
testnet
channel does not come with theforc-deploy
plugin included by default when you specified in a toolchain file. This is not ideal behaviour, but will have to do for now. Specifying the versions forforc
andfuel-core
includes the necessary plugin and fixes things.Checklist