Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix link #3459

Merged
merged 4 commits into from
Dec 9, 2024
Merged

chore: fix link #3459

merged 4 commits into from
Dec 9, 2024

Conversation

petertonysmith94
Copy link
Contributor

Summary

  • Link not being parsed correctly with the docs-hub (see here)
  • Added documentation for the correct format of links.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the docs Requests pertinent to documentation label Dec 9, 2024
@petertonysmith94 petertonysmith94 self-assigned this Dec 9, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 1:00pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 1:00pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 1:00pm

@github-actions github-actions bot added the chore Issue is a chore label Dec 9, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3459 will not alter performance

Comparing ps/docs/fix-link (b56ec5b) with master (7390114)

Summary

✅ 18 untouched benchmarks

@petertonysmith94 petertonysmith94 marked this pull request as ready for review December 9, 2024 12:32
This was referenced Dec 9, 2024
Open
Merged
@petertonysmith94 petertonysmith94 enabled auto-merge (squash) December 9, 2024 13:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Coverage Report:

Lines Branches Functions Statements
76.42%(+0%) 69.94%(+0%) 74.46%(+0%) 76.45%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit 6d0fe76 into master Dec 9, 2024
25 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/docs/fix-link branch December 9, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore docs Requests pertinent to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petertonysmith94 @arboleya @danielbate @Torres-ssf @Dhaiwat10