Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: transaction coder #3457

Closed
wants to merge 26 commits into from
Closed

feat: transaction coder #3457

wants to merge 26 commits into from

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Dec 8, 2024 •
edited
Loading

Summary

  • Refactored the @fuel-ts/transaction based coders to use the new @fuel-ts/abi package.
  • Removed the Receipt based coders.

Breaking Changes

TBD

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94
feat: implemented byteArray coder
0389e22
@petertonysmith94
feat: added txPointerCoder
bc6ba12
@petertonysmith94
chore: removed strict validation for struct values
ec8a87b
@petertonysmith94
Merge branch 'ns/feat/abi-parser' of github.com:FuelLabs/fuels-ts int…
b8c9d82 
…o ps/feat/transaction-coder
@petertonysmith94
Revert "Merge branch 'ns/feat/abi-parser' of github.com:FuelLabs/fuel…
94fe237 
…s-ts into ps/feat/transaction-coder"

This reverts commit b8c9d82, reversing
changes made to ec8a87b.
@petertonysmith94
chore: fixed txPointer
bd453c5
@petertonysmith94
docs: fixing API links
885b532
@petertonysmith94
chore: removed deprecated receipt coders
766e71c
@petertonysmith94
feat: added storage slot coder
cec4d1c
@petertonysmith94
feat: upgrade purpose
d081e70
@petertonysmith94
feat: refactored the output coder
0eb33ba
@petertonysmith94
feat: PoliciesCoder
1209eb5
@petertonysmith94
feat: refactored utxo id
cfa74ed
@petertonysmith94
feat: input coders
54bddd1
@petertonysmith94
feat: WitnessCoder
e22146b
@petertonysmith94
chore: removed old coders from upgrade purposes tests
93eb1bc
@petertonysmith94
feat: Transaction coders
7009a4e
@petertonysmith94
chore: removed abi-coder package from transactions
79832e0
@petertonysmith94
Merge branch 'ps/feat/abi-coder' of github.com:FuelLabs/fuels-ts into…
7fcf2df 
… ps/feat/transaction-coder
@petertonysmith94
chore: removed CoderType
ff71827
@petertonysmith94
feat: finalized transaction coders
a15e0af
@petertonysmith94 petertonysmith94 added the feat Issue is a feature label Dec 8, 2024
@petertonysmith94 petertonysmith94 self-assigned this Dec 8, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 7:51pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 7:51pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 7:51pm

@petertonysmith94 petertonysmith94 changed the base branch from ps/feat/abi-coder to master December 8, 2024 21:22
@petertonysmith94 petertonysmith94 changed the base branch from master to ps/feat/abi-coder December 8, 2024 21:23
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3457 will degrade performances by 54.64%

Comparing ps/feat/transaction-coder (bb4bbf2) with ps/feat/abi-coder (51b0ac8)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark ps/feat/abi-coder ps/feat/transaction-coder Change
❌ should successfully transfer a single asset between wallets (x20 times) 60.6 ms 133.7 ms -54.64%

@petertonysmith94
Copy link
Contributor Author

Closed in favour of merging into #3402

@petertonysmith94 petertonysmith94 deleted the ps/feat/transaction-coder branch December 9, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm Awaiting requested review from digorithm digorithm will be requested when the pull request is marked ready for review digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya will be requested when the pull request is marked ready for review arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf will be requested when the pull request is marked ready for review Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 will be requested when the pull request is marked ready for review Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate will be requested when the pull request is marked ready for review danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk will be requested when the pull request is marked ready for review nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad will be requested when the pull request is marked ready for review maschad is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@petertonysmith94