Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update internally used chain config #3420

Merged
merged 45 commits into from
Dec 11, 2024
Merged

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Nov 25, 2024

Summary

This PR updates our internally used chain config to match the one specified here and removes all the state from our default stateConfig.json files.

Things to note:

  • The consensus_parameters have been updated from V1 to V2 in the chain config files.
  • For create fuels and fuels CLI:
# Before all these addresses had funds
0x09c0b2d1a486c439a87bcba6b46a7a1a23f3897cc83a94521a96da5c23bc58db
0x09dd7a49174d6fcc9f4c6f7942c18060a935ddd03ee69b594189b8c3581276ea
0x1c31df52b6df56407dd95f83082e8beb9cfc9532ac111d5bd8491651d95ba775
0x3b24509ed4ab3c7959f5c9391c1445c59290cdb5f13d6f780922f376b7029f30
0x49075a7538e2c88ebe1926ce4d898198a2a4e790d14512943a9864bc536b3c82
0x5d99ee966b42cd8fc7bdd1364b389153a9e78b42b7d4a691470674e817888d4e
0x6a2c4691c547c43924650dbd30620b184b5fe3fb6dbe5c4446110b08f6f405bf
0x77c6f40b7da70d885f68efaad7c661327482a63ea10dcb4271de819438254ae1
0x7e3626e306588eba79cafab73f0709e55ab8f4bdfe8c8b75034a430fc56ece89
0x86604282dc604481b809845be49667607c470644f6822fc01eb0d22f167e08cf
0x94ffcc53b892684acefaebc8a3d4a595e528a8cf664eeb3ef36f1020b0809d0d
0x95a7aa6cc32743f8706c40ef49a7423b47da763bb4bbc055b1f07254dc729036
0xb32197cf75efe05bf453c26178139f09b391582065549c1422bc92555ecffb64
0xbca334a06d19db5041c78fe2f465b07be5bec828f38b7796b2877e7d1542c950
0xbd9a1dc8d3ec3521c43f6c2c01611b4d0204c7610204ff0178488c8738a30bd2
0xbdaad6a89e073e177895b3e5a9ccd15806749eda134a6438dae32fc5b6601f3f
0xcee104acd38b940c8f1c62c6d7ea00a0ad2241d6dee0509a4bf27297508870d3

# Now only these addresses are pre-funded
0x09c0b2d1a486c439a87bcba6b46a7a1a23f3897cc83a94521a96da5c23bc58db
0x94ffcc53b892684acefaebc8a3d4a595e528a8cf664eeb3ef36f1020b0809d0d

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Dhaiwat10 Dhaiwat10 added the chore Issue is a chore label Nov 25, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Nov 25, 2024
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 8:59am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 8:59am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 8:59am

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhaiwat10 will the differences between the local and ignition chains cause issues here? Consensus parameters version for local is V2 and for ignition (and other configs) it is V1.

@Dhaiwat10
Copy link
Member Author

@petertonysmith94 That's a good point. I'm not really sure which one we are supposed to use. I heard from one of the team members that apparently the local config specified by them hasn't been updated in a long time. I'm not sure why the local is V2 and not mainnet, either.

Gonna try a few things and get back with some more context for our sync.

@Torres-ssf
Copy link
Contributor

Torres-ssf commented Nov 25, 2024

It seems our local test chain config uses settings from the Testnet upgrade number 6

Maybe we should go for either the latest Testnet upgrade (upgrade number 9) or even the lastest Mainet Upgrade

Both of them seem to be using the V2 for consensus_parameters already.

This will require changes only on our side if I am not mistaken, and only on TS types related to test helpers.

It seems that even though these versions are being updated on the chain config JSON for main-net and test-net, fuel-core always resolves them to V1 when returning the response for the graphQL queries. I believe this is due to backward compatibility reasons.

Screenshot 2024-11-25 at 10 57 01 AM Screenshot 2024-11-25 at 10 56 48 AM

@Dhaiwat10
Copy link
Member Author

@Torres-ssf can you check the changes I made and if they make sense?

Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #3420 will not alter performance

Comparing dp/update-chain-config (e0134e6) with master (a8af330)

Summary

✅ 18 untouched benchmarks

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we should wait to merge this until the breaking change window.

At the very least, we should add release notes and a detailed summary around this - as it could affect the end consumer and should have migration notes.

Copy link
Member

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petertonysmith94 happy to wait if their are concerns, but I'd personally prioritise parity with mainnet. I assume consumers aren't using our exported chain config for testing as they are seeing different results in mainnet.

@Torres-ssf
Copy link
Contributor

But @petertonysmith94, this PR does not introduce breaking changes.

@petertonysmith94
Copy link
Contributor

petertonysmith94 commented Dec 9, 2024

@petertonysmith94 happy to wait if their are concerns, but I'd personally prioritise parity with mainnet. I assume consumers aren't using our exported chain config for testing as they are seeing different results in mainnet.

@danielbate I do agree we should prioritise parity with mainnet - hence the approval.

But @petertonysmith94, this PR does not introduce breaking changes.

@Torres-ssf For me, the state config changes and, thereby, the changes to wallets with funds in both the fuels CLI and testing infrastructure are breaking changes. I believe I'm just being overly cautious, though.

I think it's worth adding a summary about:

  • The below wallet addresses
  • V1 -> V2 namespace on the consensus_parameters
# Before all these addresses had funds
0x09c0b2d1a486c439a87bcba6b46a7a1a23f3897cc83a94521a96da5c23bc58db
0x09dd7a49174d6fcc9f4c6f7942c18060a935ddd03ee69b594189b8c3581276ea
0x1c31df52b6df56407dd95f83082e8beb9cfc9532ac111d5bd8491651d95ba775
0x3b24509ed4ab3c7959f5c9391c1445c59290cdb5f13d6f780922f376b7029f30
0x49075a7538e2c88ebe1926ce4d898198a2a4e790d14512943a9864bc536b3c82
0x5d99ee966b42cd8fc7bdd1364b389153a9e78b42b7d4a691470674e817888d4e
0x6a2c4691c547c43924650dbd30620b184b5fe3fb6dbe5c4446110b08f6f405bf
0x77c6f40b7da70d885f68efaad7c661327482a63ea10dcb4271de819438254ae1
0x7e3626e306588eba79cafab73f0709e55ab8f4bdfe8c8b75034a430fc56ece89
0x86604282dc604481b809845be49667607c470644f6822fc01eb0d22f167e08cf
0x94ffcc53b892684acefaebc8a3d4a595e528a8cf664eeb3ef36f1020b0809d0d
0x95a7aa6cc32743f8706c40ef49a7423b47da763bb4bbc055b1f07254dc729036
0xb32197cf75efe05bf453c26178139f09b391582065549c1422bc92555ecffb64
0xbca334a06d19db5041c78fe2f465b07be5bec828f38b7796b2877e7d1542c950
0xbd9a1dc8d3ec3521c43f6c2c01611b4d0204c7610204ff0178488c8738a30bd2
0xbdaad6a89e073e177895b3e5a9ccd15806749eda134a6438dae32fc5b6601f3f
0xcee104acd38b940c8f1c62c6d7ea00a0ad2241d6dee0509a4bf27297508870d3
# Now only these addresses are pre-funded
0x09c0b2d1a486c439a87bcba6b46a7a1a23f3897cc83a94521a96da5c23bc58db
0x94ffcc53b892684acefaebc8a3d4a595e528a8cf664eeb3ef36f1020b0809d0d

@Dhaiwat10
Copy link
Member Author

@petertonysmith94 happy to wait until after the code freeze. Does that sound good?

@petertonysmith94
Copy link
Contributor

@petertonysmith94 happy to wait until after the code freeze. Does that sound good?

I'm happy for it to go out, just good to have the PR description detailing the change and release notes

@Dhaiwat10
Copy link
Member Author

Dhaiwat10 commented Dec 11, 2024

@petertonysmith94 does the description look good now? Feel free to edit further if you want to :)

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.33%(-0.01%) 69.84%(-0.02%) 74.2%(-0.1%) 76.34%(-0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/test-utils/launchNode.ts 95.37%
(-1.77%)
82.53%
(-2.21%)
89.47%
(-10.53%)
93.8%
(-3.47%)

@petertonysmith94
Copy link
Contributor

@petertonysmith94 does the description look good now? Feel free to edit further if you want to :)

Just missing release notes :)

@arboleya
Copy link
Member

@petertonysmith94 A summary suffices I think, no need for release notes on this one.

Remember that all PRs are still mentioned and listed on the release's changelog.

The release notes are just a premium spot to advertise more relevant things.

@petertonysmith94
Copy link
Contributor

@petertonysmith94 A summary suffices I think, no need for release notes on this one.

Remember that all PRs are still mentioned and listed on the release's changelog.

The release notes are just a premium spot to advertise more relevant things.

I trust your judgment on this one.

@Dhaiwat10
Copy link
Member Author

Removed release notes

@Dhaiwat10 Dhaiwat10 merged commit ebe5ecd into master Dec 11, 2024
48 of 49 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/update-chain-config branch December 11, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update internally used Chain Config Remove all state from default stateConfig.json
6 participants