Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add source request header #3282

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

danielbate
Copy link
Member

@danielbate danielbate commented Oct 9, 2024

Release notes

In this release, we:

  • Added a new header for GraphQL requests with the fuels version used

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 6:23am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 6:23am

Copy link

codspeed-hq bot commented Oct 9, 2024

CodSpeed Performance Report

Merging #3282 will not alter performance

Comparing db/feat/source-request-header (84f234a) with master (04578ed)

Summary

✅ 18 untouched benchmarks

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Coverage Report:

Lines Branches Functions Statements
76.28%(+0%) 70.27%(-0.02%) 75.26%(+0%) 76.4%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 71.36%
(+0%)
63.81%
(-0.36%)
73.91%
(+0%)
70.99%
(+0%)

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when this is a tmp release?

@nedsalk
Copy link
Contributor

nedsalk commented Oct 9, 2024

@petertonysmith94 What happens when this is a tmp release?

I'd add this support in a follow-up PR as it'd require more work to implement given that the version of a temporary release isn't stored in the sdk. We'd either have to read the version installed on the user's disk or add some automation to update the getBuiltinVersions return for temporary releases.

@petertonysmith94
Copy link
Contributor

petertonysmith94 commented Oct 9, 2024

What happens when this is a tmp release?

I'd add this support in a follow-up PR as it'd require more work to implement given that the version of a temporary release isn't stored in the sdk. We'd either have to read the version installed on the user's disk or add some automation to update the getBuiltinVersions return for temporary releases.

Already on it.

@petertonysmith94 petertonysmith94 merged commit c84abb3 into master Oct 9, 2024
47 of 56 checks passed
@petertonysmith94 petertonysmith94 deleted the db/feat/source-request-header branch October 9, 2024 09:34
Dhaiwat10 pushed a commit that referenced this pull request Nov 19, 2024
* feat: add source request header

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding especial header to GQL requests
4 participants