Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update workflows to include next branch #3234

Merged
merged 3 commits into from
Oct 1, 2024
Merged

ci: update workflows to include next branch #3234

merged 3 commits into from
Oct 1, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented Sep 30, 2024 •
edited
Loading

Summary

This updates the required workflows to ensure they run on pull requests to any next branch that we may have.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@vercel Vercel
Copy link

vercel bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 9:53pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 9:53pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 30, 2024 9:53pm

@github-actions github-actions bot added the chore Issue is a chore label Sep 30, 2024
@maschad maschad changed the base branch from master to next September 30, 2024 19:38
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.67%(+0%) 71.48%(+0%) 75.65%(+0%) 76.76%(+0%)
Changed Files:

Coverage values did not change👌.

@maschad maschad enabled auto-merge (squash) September 30, 2024 21:49
@maschad maschad self-assigned this Sep 30, 2024
nedsalk
nedsalk approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@nedsalk nedsalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay, but maybe you could increase the scope of the PR to include some other places where a check is done something == 'master'?

@maschad maschad merged commit f8d2c7e into next Oct 1, 2024
24 checks passed
@maschad maschad deleted the update-workflows-next branch October 1, 2024 07:42
maschad added a commit that referenced this pull request Oct 1, 2024
@maschad
ci: update workflows to include next branch (#3234)
3c30cd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm

@arboleya arboleya Awaiting requested review from arboleya

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10

Assignees

@maschad maschad

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maschad @danielbate @petertonysmith94 @nedsalk