Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unskip test case #3093

Merged
merged 9 commits into from
Sep 4, 2024
Merged

chore: unskip test case #3093

merged 9 commits into from
Sep 4, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Sep 3, 2024 •
edited
Loading

Summary

This PR addresses 2 things:

  1. Unskip a test case
  2. Remove a skip test case that is not needed

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf added the chore Issue is a chore label Sep 3, 2024
@Torres-ssf Torres-ssf self-assigned this Sep 3, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 11:06am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 11:06am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 4, 2024 11:06am

@Torres-ssf Torres-ssf marked this pull request as ready for review September 4, 2024 00:51
@Torres-ssf Torres-ssf enabled auto-merge (squash) September 4, 2024 10:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Coverage Report:

Lines Branches Functions Statements
79.38%(+0%) 72.07%(+0.03%) 77.77%(+0%) 79.45%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 71.15%
(+0%)		 64.53%
(+0.5%)		 74.19%
(+0%)		 70.79%
(+0%)

@Torres-ssf Torres-ssf merged commit 6faabd2 into master Sep 4, 2024
23 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/unskip-test branch September 4, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Torres-ssf @arboleya @danielbate @maschad