Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove u64 from NumberCoderType #3062

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

bajpai244
Copy link
Contributor

@bajpai244 bajpai244 commented Aug 30, 2024

Summary

We remove the u64 type from NumberCoderType.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 11:56am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 11:56am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Aug 30, 2024 11:56am

Copy link

vercel bot commented Aug 30, 2024

@bajpai244 is attempting to deploy a commit to the Fuel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the bug Issue is a bug label Aug 30, 2024
@CLAassistant
Copy link

CLAassistant commented Aug 30, 2024

CLA assistant check
All committers have signed the CLA.

@danielbate danielbate changed the title fix: remove 'u64' from NumberCoderType fix: remove u64 from NumberCoderType Aug 30, 2024
@danielbate
Copy link
Member

Please can you add a changeset :) Go to the root directory and run pnpm changeset, we'll just need a patch for the abi-coder package and make the description:

fix: remove u64 from NumberCoderType

@bajpai244
Copy link
Contributor Author

fix: remove u64 from NumberCoderTyp

@danielbate changeset added :)

.changeset/light-lizards-help.md Outdated Show resolved Hide resolved
.changeset/light-lizards-help.md Outdated Show resolved Hide resolved
@danielbate
Copy link
Member

Just need to sign the CLA stage @bajpai244 and should be good to go :)

Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bajpai244 Good catch!

Thanks for the contribution. ❤️

@bajpai244
Copy link
Contributor Author

@danielbate signed the CLA :)

@arboleya arboleya enabled auto-merge (squash) August 30, 2024 11:56
@arboleya arboleya merged commit 2b45e8d into FuelLabs:master Aug 30, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove u64 from NumberCoderType Union
6 participants