Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make vite the default create-fuels template #3048

Merged
merged 39 commits into from
Sep 3, 2024
Merged

feat: make vite the default create-fuels template #3048

merged 39 commits into from
Sep 3, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Aug 28, 2024 •
edited
Loading

Release notes

In this release, we:

  • Made vite the default template for create-fuels

Summary

This PR adjusts our docs and the CLI code for create-fuels to make vite the new default template for the tool.

Breaking Changes

If no --template is specified, npm create fuels will now bootstrap a Vite app instead of a Next.js app.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Dhaiwat10 Dhaiwat10 added the chore Issue is a chore label Aug 28, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Aug 28, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 6:15pm
fuels-ts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 6:15pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 6:15pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 3, 2024 6:15pm

@github-actions github-actions bot added the feat Issue is a feature label Aug 28, 2024
@Dhaiwat10 Dhaiwat10 removed the feat Issue is a feature label Aug 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2024 •
edited
Loading

This PR is published in NPM with version 0.0.0-pr-3048-20240903130952

danielbate
danielbate reviewed Sep 3, 2024
View reviewed changes
.github/workflows/test.yaml Outdated Show resolved Hide resolved
.github/workflows/test.yaml Outdated Show resolved Hide resolved
danielbate
danielbate previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💪🏻

petertonysmith94
petertonysmith94 previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

playwright-tests/create-fuels.test.ts Outdated Show resolved Hide resolved
playwright-tests/create-fuels.test.ts Show resolved Hide resolved
@github-actions github-actions bot added the feat Issue is a feature label Sep 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Coverage Report:

Lines Branches Functions Statements
79.24%(-0.28%) 71.99%(-0.05%) 77.51%(-0.53%) 79.31%(-0.31%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ apps/create-fuels-counter-guide/src/main.tsx 0%
(+0%)		 0%
(+0%)		 100%
(+100%)		 0%
(+0%)
🔴 ✨ apps/create-fuels-counter-guide/src/routeTree.gen.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ apps/create-fuels-counter-guide/src/routes/__root.tsx 0%
(+0%)		 0%
(+0%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ apps/create-fuels-counter-guide/src/routes/faucet.lazy.tsx 0%
(+0%)		 0%
(+0%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ apps/create-fuels-counter-guide/src/routes/index.lazy.tsx 0%
(+0%)		 0%
(+0%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ apps/create-fuels-counter-guide/src/routes/predicate.lazy.tsx 0%
(+0%)		 0%
(+0%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ apps/create-fuels-counter-guide/src/routes/script.lazy.tsx 0%
(+0%)		 0%
(+0%)		 0%
(+0%)		 0%
(+0%)

@Dhaiwat10 Dhaiwat10 merged commit a0bb25f into master Sep 3, 2024
29 of 35 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/vite-default branch September 3, 2024 18:37
@fuel-service-user fuel-service-user mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@maschad maschad maschad approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
chore Issue is a chore feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make vite the default template for create fuels
4 participants
@Dhaiwat10 @danielbate @maschad @petertonysmith94