-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate blob IDs against chain in chunk deploys #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
danielbate
commented
Aug 28, 2024
…/feat/validate-blob-ids
…/feat/validate-blob-ids
danielbate
changed the title
feat: validate blob IDs against chain
feat: validate blob IDs against chain in chunk deploys
Sep 2, 2024
…/feat/validate-blob-ids
danielbate
requested review from
digorithm,
Torres-ssf,
Dhaiwat10,
nedsalk,
petertonysmith94 and
maschad
as code owners
September 2, 2024 11:18
nedsalk
reviewed
Sep 2, 2024
arboleya
previously approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left an optional and trivial nit.
Looking good otherwise. 🚀
arboleya
previously approved these changes
Sep 2, 2024
Torres-ssf
previously approved these changes
Sep 2, 2024
Co-authored-by: Peter Smith <[email protected]>
Torres-ssf
approved these changes
Sep 3, 2024
arboleya
approved these changes
Sep 3, 2024
petertonysmith94
approved these changes
Sep 3, 2024
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
Summary
Uses the new
blob()
endpoint in[email protected]
to validate a blob ID against before submitting it. Utilises GraqhQL to query for any number of blobs, as theblob()
endpoint is constrained to a single ID.Checklist