Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate blob IDs against chain in chunk deploys #3047

Merged
merged 12 commits into from
Sep 3, 2024

Conversation

danielbate
Copy link
Member

@danielbate danielbate commented Aug 28, 2024

Release notes

In this release, we:

  • Reduced the cost of submitting blob contract deploys where a blob has already been uploaded

Summary

Uses the new blob() endpoint in [email protected] to validate a blob ID against before submitting it. Utilises GraqhQL to query for any number of blobs, as the blob() endpoint is constrained to a single ID.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@danielbate danielbate added the feat Issue is a feature label Aug 28, 2024
@danielbate danielbate self-assigned this Aug 28, 2024
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 11:29am
fuels-ts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 11:29am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 11:29am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 3, 2024 11:29am

@danielbate danielbate changed the title feat: validate blob IDs against chain feat: validate blob IDs against chain in chunk deploys Sep 2, 2024
arboleya
arboleya previously approved these changes Sep 2, 2024
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an optional and trivial nit.

Looking good otherwise. 🚀

packages/account/src/providers/provider.ts Outdated Show resolved Hide resolved
arboleya
arboleya previously approved these changes Sep 2, 2024
Torres-ssf
Torres-ssf previously approved these changes Sep 2, 2024
@danielbate danielbate enabled auto-merge (squash) September 2, 2024 17:09
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Coverage Report:

Lines Branches Functions Statements
79.43%(-0.12%) 71.88%(+0.01%) 77.69%(-0.31%) 79.53%(-0.15%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 69.08%
(-1.38%)
62.56%
(+0.91%)
71.27%
(-4.92%)
68.77%
(-1.6%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.48%
(+0%)
79.71%
(+1.45%)
84%
(+0%)
88.73%
(+0%)
🔴 packages/contract/src/contract-factory.ts 32.6%
(-0.48%)
26.66%
(-0.92%)
34.78%
(-1.58%)
31.91%
(-0.69%)

@danielbate danielbate merged commit 6bef838 into master Sep 3, 2024
23 checks passed
@danielbate danielbate deleted the db/feat/validate-blob-ids branch September 3, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for Blobs' existence before uploading them
5 participants