fix: fuels dev cleanup not killing node

[nedsalk]

• Closes Exiting fuels dev with CTRL+C (SIGINT) doesn't kill fuel-core node #2889

Checklist

• All changes are covered by tests (or not applicable)
• All changes are documented (or not applicable)
• I reviewed the entire PR myself (preferably, on GH UI)
• I described all Breaking Changes (or there's none)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
create-fuels-template	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 3, 2025 11:15am
fuels-template	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 3, 2025 11:15am
ts-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 3, 2025 11:15am
ts-docs-api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 3, 2025 11:15am

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
create-fuels-counter-example	⬜️ Ignored (Inspect)			Jan 3, 2025 11:15am
create-fuels-template-preview	⬜️ Ignored (Inspect)			Jan 3, 2025 11:15am

[nedsalk]

Removing this line caused the issue to go away.

I suspect that the root cause of the problem is somewhere in the fuels package because this line didn't cause problems to e.g. launchTestNode. It might be in the interplay between file watchers registered in the dev command and this cleanup function removing the files they're watching, but I couldn't pinpoint the actual root cause. I tried deleting lines I think might be causing it while having this line still on, but to no avail. We can search for the root cause in another issue that's of lesser priority.

The cleanup still happens because of the error and exit event listeners registered on the child above.

[codspeed-hq]

CodSpeed Performance Report

Merging #3038 will not alter performance

_{Comparing ns/fix/fuels-dev-node-cleanup (3f525ce) with master (27e8808)}

Summary

✅ 18 untouched benchmarks

[nedsalk]

I added these to the path so that the spawn can run from the cwd of the temporary test project instead of running pnpm fuels init --path ${paths.init} from our repo's root. Both of them are using the fuels-forc under the hood, but it feels more correct to have all the commands be running from inside the temporary test folder, pnpm fuels init included.

As an alternative, I could initiate the temporary project and pass in the --fuel-core-path and --forc-path arguments to point to these binaries. I opted for adding forc and fuel-core to the path like this because this wasn't the first time I had to debug this problem only to come to the conclusion that forc and fuel-core aren't in the path.

[github-actions]

Coverage Report:

Lines	Branches	Functions	Statements
77.77%(-0.01%)	70.4%(+0%)	75.37%(-0.01%)	77.74%(+0%)

Changed Files:

Ok	File (✨=New File)	Lines	Branches	Functions	Statements
🔴	packages/account/src/test-utils/launchNode.ts	95.32% (-0.05%)	80.95% (-1.58%)	89.47% (+0%)	93.75% (-0.05%)
🔴	packages/create-fuels/src/lib/getPackageManager.ts	100% (+0%)	88.88% (+8.88%)	100% (+0%)	100% (+0%)