Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: revert gas price estimation test flakiness #2993

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented Aug 21, 2024

Summary

This reverts commit f6b12bd which was originally a patch fix for FuelLabs/fuel-core#2107 , which has now been merged. This can be set to ready for review once we've upgraded to a version greater than fuel-core v0.34.0.

Blocked by #3052

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@maschad maschad self-assigned this Aug 21, 2024
@maschad maschad changed the title Revert "fix: gas price estimation test flakiness (#2981)" ci: revert gas price estimation test flakiness Aug 21, 2024
@github-actions github-actions bot added the chore Issue is a chore label Aug 21, 2024
@Torres-ssf
Copy link
Contributor

Torres-ssf commented Aug 22, 2024

@maschad We cannot revert this commit just yet. The fix for this problem is not included on 0.34.0, I've checked this: 927de16

@maschad
Copy link
Member Author

maschad commented Aug 22, 2024

@maschad We cannot revert this commit just yet. The fix for this problem is not included on 0.34.0, I've checked this: 927de16

I think you may have misread the PR's description which states "once we've upgraded to a version greater than fuel-core v0.34.0."

@Torres-ssf
Copy link
Contributor

@maschad We cannot revert this commit just yet. The fix for this problem is not included on 0.34.0, I've checked this: 927de16

I think you may have misread the PR's description which states "once we've upgraded to a version greater than fuel-core v0.34.0."

@maschad You're correct. I apologize for the confusion.

@arboleya arboleya removed the blocked label Aug 29, 2024
@maschad maschad added the blocked label Sep 2, 2024
@maschad maschad requested a review from arboleya September 3, 2024 17:07
Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 3:33pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 3:33pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 4, 2024 3:33pm

Co-authored-by: Anderson Arboleya <[email protected]>
@maschad maschad removed the blocked label Sep 3, 2024
@maschad maschad marked this pull request as ready for review September 3, 2024 19:09
@maschad maschad requested a review from digorithm as a code owner September 3, 2024 19:09
@arboleya arboleya enabled auto-merge (squash) September 4, 2024 15:29
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Coverage Report:

Lines Branches Functions Statements
79.4%(+0%) 72.12%(+0%) 77.76%(-0.01%) 79.47%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/test-utils/launchNode.ts 97.05%
(-0.03%)
87.71%
(+0%)
100%
(+0%)
97.19%
(-0.03%)

@arboleya arboleya merged commit 24d4d03 into master Sep 4, 2024
23 checks passed
@arboleya arboleya deleted the mc/ci/revert-gas-price-estimation-fix branch September 4, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants