fix: include a .gitignore file in the copied over template from create-fuels
#1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhaiwat10
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate and
nedsalk
as code owners
arboleya
reviewed
Jan 5, 2024
…bs/fuels-ts into dp/create-fuels-gitignore
|
It needs to be against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm doesn't include
.gitignorefiles in package binaries once published to npm. This is why the source code of our templates - once publishsed to npm - didn't have a .gitignore file with it.To go around this, I have added an extra file called
gitignore(without the . at the start) so that npm includes it in the bundle. This file is then renamed to.gitignoreby the CLI tool when it extracts the template.I have also kept the
.gitignoresince the template folder is built out during our monorepo's build and we want the resulting build artifacts ignored.This is not the fanciest solution but it is the one I've seen most commonly used by scaffolding CLI projects, even by
create-next-app.Closes #1612