refactor: remove hacky solution to get right witness offset (#1494)

FuelLabs · Dec 11, 2023 · 2f70ac6 · 2f70ac6
1 parent 4ecd643
commit 2f70ac6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/.changeset/moody-walls-admire.md b/.changeset/moody-walls-admire.md
@@ -0,0 +1,5 @@
+---
+"@fuel-ts/transactions": minor
+---
+
+remove hacky solution to get right witness offset
diff --git a/packages/transactions/src/coders/witness.test.ts b/packages/transactions/src/coders/witness.test.ts
@@ -8,7 +8,6 @@ describe('WitnessCoder', () => {
     const witness: Witness = {
       dataLength: 0,
       data: '0x',
-      offset: 0,
     };
 
     const encoded = hexlify(new WitnessCoder().encode(witness));
@@ -25,7 +24,6 @@ describe('WitnessCoder', () => {
     const witness: Witness = {
       dataLength: 4,
       data: '0xdeadbeef',
-      offset: 0,
     };
 
     const encoded = hexlify(new WitnessCoder().encode(witness));

diff --git a/packages/transactions/src/coders/witness.ts b/packages/transactions/src/coders/witness.ts
@@ -8,11 +8,6 @@ export type Witness = {
   dataLength: number;
   /** Witness data (byte[]) */
   data: string;
-  /**
-   * TODO: Temporary solution, remove after fixing
-   * https://github.com/FuelLabs/fuels-ts/issues/1331
-   */
-  offset?: number;
 };
 
 export class WitnessCoder extends Coder<Witness, Witness> {
@@ -47,7 +42,6 @@ export class WitnessCoder extends Coder<Witness, Witness> {
       {
         dataLength,
         data: witnessData,
-        offset,
       },
       o,
     ];