-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily remove no_std
support
#60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failing for some reason
You'll also need to update CI to run a build/test in no-std mode. Something similar to this: https://github.com/FuelLabs/fuel-types/blob/master/.github/workflows/ci.yml#L49
|
Uuuugh, this is very weird. The following test https://github.com/FuelLabs/fuels-rs/blob/master/fuels-rs/tests/calls.rs#L17 is failing because However, this is only happening in this CI server (!), and locally I can build it just fine:
Crazy, uh? I then decided to put an Note that this is happening everywhere else, not just this branch. Even on cc @adlerjohn @Voxelot @vnepveu Edit: for now I'll keep this failing test as |
Update After a discussion that happened in the infra sync call with @Voxelot and @tjsharp1, we've decided to unblock the |
Can you also update the description of the PR? I'm not actually sure what this PR does. |
no_std
support
Nice catch, that wasn't making any sense anymore. Title and description updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would prefer weigh-in from @Voxelot
Currently, we created a
no_std
feature to handle wasm builds. However, this causescargo build --all-features
to break, which shouldn't happen. Instead, we should have astd
feature-set set as default, as per the official Rust docs:This PR temporarily removes the
no_std
so the CI won't break and this issue (#62) captures the future work that needs to be done in order to properly enableno_std
compatibility.Closes #52.