refactor!: use submit_and_await_commit API
#1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iqdecay
requested review from
digorithm,
hal3e,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
MujkicA
reviewed
Nov 6, 2023
iqdecay
force-pushed
the
iqdecay/refactor-await-commit-api
branch
from
4d6d4fd to
23787c9
Compare
|
@MujkicA I added some more context and re-added the removed function. |
Br1ght0ne
previously approved these changes
Dec 19, 2023
hal3e
requested changes
Dec 19, 2023
iqdecay
changed the title
submit_and_await_commit APIsubmit_and_await_commit API
Br1ght0ne
approved these changes
Dec 21, 2023
|
@FuelLabs/sdk-rust can we please move this forward |
segfault-magnet
approved these changes
Jan 8, 2024
Salka1988
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1180, #1128.
This PR uses the correct API for sending a transaction and ensuring that we wait for the commit of the transaction before returning.
This is needed because otherwise there might be a disconnect between submitting the transaction and awaiting for its commit, if it is done using the two separate APIs as before.
Further work will be needed as part of #1188
BREAKING CHANGE:
send_transaction_and_await_commitfunction now returns aTxStatusinstead ofTxId.