Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: securely zero out SecretKeys from memory #1161

Merged
merged 4 commits into from
Oct 10, 2023
Merged

feat: securely zero out SecretKeys from memory #1161

merged 4 commits into from
Oct 10, 2023

Conversation

Br1ght0ne
Copy link
Contributor

Close #1157.
These are all the relevant usages of SecretKey @segfault-magnet proposed - I found no more usages.

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@Br1ght0ne Br1ght0ne added tech-debt Improves code quality or safety package:core labels Oct 10, 2023
@Br1ght0ne Br1ght0ne self-assigned this Oct 10, 2023
hal3e
hal3e approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Br1ght0ne Br1ght0ne merged commit 2625f90 into master Oct 10, 2023
38 checks passed
@Br1ght0ne Br1ght0ne deleted the oleksii/zeroize branch October 10, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@hal3e hal3e hal3e approved these changes

@iqdecay iqdecay iqdecay approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@Br1ght0ne Br1ght0ne

Labels
package:core tech-debt Improves code quality or safety
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use zeroized for zeroing out memory that housed secrets
4 participants
@Br1ght0ne @iqdecay @hal3e @segfault-magnet